Skip to content

fix(TimesCircleIcon): Replace TimesCircleIcon with RhUiCloseCircleFillIcon#12513

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-times-circle-icon-with-rh-ui-close-circle-fill
Open

fix(TimesCircleIcon): Replace TimesCircleIcon with RhUiCloseCircleFillIcon#12513
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-times-circle-icon-with-rh-ui-close-circle-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated status indicator icons across file upload components, detailed view panels, and associated layout examples. The new icon styling for danger and warning states aligns with the design system standards, enhancing visual consistency and improving the overall appearance of the user interface.

…lIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6e98c250-0207-4527-ae89-4a83042f2fe8

📥 Commits

Reviewing files that changed from the base of the PR and between a479b4c and af9ef3e.

📒 Files selected for processing (5)
  • packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx

Walkthrough

TimesCircleIcon is replaced with RhUiCloseCircleFillIcon in MultipleFileUploadStatus (import and 'danger' branch of the icon-selection useEffect) and across three PrimaryDetail demo components and their accompanying markdown file.

Changes

Icon replacement across component and demos

Layer / File(s) Summary
MultipleFileUploadStatus danger icon update
packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx
Import switched from TimesCircleIcon to RhUiCloseCircleFillIcon; the useEffect branch for statusToggleIcon === 'danger' now sets the icon to RhUiCloseCircleFillIcon.
PrimaryDetail demo variants icon update
packages/react-core/src/demos/PrimaryDetail.md, packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx, packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx, packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
Icon imports updated and two DataListItem row renderings per demo file (items 2 and 4) now use RhUiCloseCircleFillIcon instead of TimesCircleIcon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • patternfly/patternfly-react#12283: Swaps TimesIconRhMicronsCloseIcon in close button/remove-icon components, part of the same close-icon migration pattern.
  • patternfly/patternfly-react#12291: Updates MultipleFileUploadStatus icon-selection logic for the 'success' branch to RhUiCheckCircleFillIcon, modifying the same useEffect this PR touches.
  • patternfly/patternfly-react#12458: Modifies MultipleFileUploadStatus.tsx icon-selection for the 'inProgress' case, directly adjacent to the 'danger' branch changed here.

Suggested reviewers

  • nicolethoen
  • kmcfaul
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing TimesCircleIcon with RhUiCloseCircleFillIcon across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 23, 2026 21:02
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants