Expose async persistence in FFI by spacebear21 · Pull Request #1287 · payjoin/rust-payjoin

spacebear21 · 2026-01-21T22:32:30Z

This exposes the async persistence methods in payjoin-ffi and accompanying unit tests in downstream languages.

I wanted to address #1199 so that we wouldn't duplicate all the hardcoded test values so much, but it turned out to be more involved than I anticipated (see my comment on that issue).

Pull Request Checklist

Please confirm the following before requesting review:

I have disclosed my use of
AI
in the body of this PR.
I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

coveralls · 2026-01-21T22:38:41Z

Pull Request Test Coverage Report for Build 21868383672

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.263%

Totals
Change from base Build 21868344426:	0.0%
Covered Lines:	10238
Relevant Lines:	12296

💛 - Coveralls

DanGould · 2026-01-27T04:48:48Z

I see the integration test is skipping. In CI: skipped 'bitcoin_ffi helpers are not available in this binding'

and local:

======================================================================
ERROR: test.test_payjoin_integration_test (unittest.loader._FailedTest.test.test_payjoin_integration_test)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_payjoin_integration_test
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 396, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 339, in _get_module_from_name
    __import__(name)
    ~~~~~~~~~~^^^^^^
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/test/test_payjoin_integration_test.py", line 11, in <module>
    import payjoin.bitcoin as bitcoinffi
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/src/payjoin/bitcoin.py", line 645, in <module>
    _UniffiLib.uniffi_bitcoin_ffi_fn_clone_address.argtypes = (
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 403, in __getattr__
    func = self.__getitem__(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 408, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: dlsym(0x6d0d1d60, uniffi_bitcoin_ffi_fn_clone_address): symbol not found

Is this entirely intentional? It was added in cc45199 #1191. I don't see discussion of just skipping the integration test there but still passing CI. Is this the intended behavior @chavic?

DanGould

One of the python tests no-ops accidentally, that's the only thing I'd really want to fix.

Would be nice to have save/load/close coverage in FFI but for now imo it's ok without.

chavic · 2026-01-27T07:16:03Z

I see the integration test is skipping. In CI: skipped 'bitcoin_ffi helpers are not available in this binding'

and local:

======================================================================
ERROR: test.test_payjoin_integration_test (unittest.loader._FailedTest.test.test_payjoin_integration_test)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_payjoin_integration_test
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 396, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 339, in _get_module_from_name
    __import__(name)
    ~~~~~~~~~~^^^^^^
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/test/test_payjoin_integration_test.py", line 11, in <module>
    import payjoin.bitcoin as bitcoinffi
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/src/payjoin/bitcoin.py", line 645, in <module>
    _UniffiLib.uniffi_bitcoin_ffi_fn_clone_address.argtypes = (
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 403, in __getattr__
    func = self.__getitem__(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 408, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: dlsym(0x6d0d1d60, uniffi_bitcoin_ffi_fn_clone_address): symbol not found

Is this entirely intentional? It was added in cc45199 #1191. I don't see discussion of just skipping the integration test there but still passing CI. Is this the intended behavior @chavic?

Yeah, that's the expected behavior

DanGould · 2026-01-27T08:44:43Z

In that case, when do we run & maintain the integration tests?

spacebear21 · 2026-01-27T11:08:05Z

Is this entirely intentional? It was added in cc45199 #1191. I don't see discussion of just skipping the integration test there but still passing CI.

Good catch, I overlooked this on PR review and haven't noticed since.. I agree it needs to be unskipped asap, though this belongs in a separate PR.

arminsabouri

Noticed on inconsistency in the dart unit tests. Otherwise Ack .

arminsabouri · 2026-01-27T13:50:45Z

Would be nice to have save/load/close coverage in FFI but for now imo it's ok without.

IIRC the persister lifecycle is covered in the integration tests.

DanGould · 2026-01-27T16:03:07Z

Would be nice to have save/load/close coverage in FFI but for now imo it's ok without.

IIRC the persister lifecycle is covered in the integration tests.

O ya that seems sufficient as long as it's actually running

edit: async & sync tho?

spacebear21 · 2026-01-28T10:17:22Z

edit: async & sync tho?

currently sync only in integration tests. Same as in the core rust tests fwiw. Maybe worth revisiting at some point for fuller coverage.

This exposes the async persistence methods in payjoin-ffi and accompanying unit tests in the downstream languages.

spacebear21 · 2026-02-10T14:25:03Z

Rebased to fix CI and addressed Armin's comment

benalleng

ACK 6314d3c I created an issue #1325 following this discussion to add fuller coverage

Addressed

payjoin#1287 added save() and save_async() coverage to the bindings but left load() and close() untested. Nothing pinned the binding layer's contract with a foreign persister: that a terminal save reaches through to close(), and that load() is a read the runtime can repeat rather than one that consumes the log. Cover the receiver and the sender in dart, javascript, python and csharp, sync and async. The two reach their terminal state by different routes: cancelling an initialized receiver is itself terminal, while cancelling a sender only moves it to a pending fallback and the session closes a step later, when the broadcast transition is saved. Assert the persister is open beforehand, closed afterwards, and that load() still returns every event.

spacebear21 force-pushed the replay-event-log-async branch 5 times, most recently from b9ab24b to aee5749 Compare January 23, 2026 20:46

spacebear21 marked this pull request as ready for review January 23, 2026 21:00

spacebear21 requested a review from arminsabouri January 23, 2026 21:00

spacebear21 mentioned this pull request Jan 24, 2026

Upgrade to Payjoin 1.0.0 SatoshiPortal/bullbitcoin-mobile#1446

Closed

DanGould previously requested changes Jan 27, 2026

View reviewed changes

Comment thread payjoin-ffi/python/test/test_payjoin_unit_test.py Outdated

spacebear21 force-pushed the replay-event-log-async branch 2 times, most recently from ee65092 to 2f94194 Compare January 27, 2026 12:17

arminsabouri previously requested changes Jan 27, 2026

View reviewed changes

Comment thread payjoin-ffi/dart/test/test_payjoin_unit_test.dart Outdated

DanGould mentioned this pull request Jan 27, 2026

Don't skip python integration test #1301

Merged

2 tasks

spacebear21 force-pushed the replay-event-log-async branch 3 times, most recently from e51ac3a to d8e5e31 Compare February 10, 2026 14:04

Expose async persistence in FFI

6314d3c

This exposes the async persistence methods in payjoin-ffi and accompanying unit tests in the downstream languages.

spacebear21 force-pushed the replay-event-log-async branch from d8e5e31 to 6314d3c Compare February 10, 2026 14:14

spacebear21 requested review from DanGould, arminsabouri and benalleng February 10, 2026 14:25

benalleng approved these changes Feb 11, 2026

View reviewed changes

benalleng mentioned this pull request Feb 11, 2026

Add more complete async test coverage #1325

Open

spacebear21 merged commit a200095 into payjoin:master Feb 11, 2026
20 checks passed

ConorOkus mentioned this pull request Apr 28, 2026

JsonSenderSessionPersister[Async] crashes WASM heap in real browsers #1508

Closed

Jolah1 mentioned this pull request Sep 3, 2026

Test persister load and close in FFI bindings #1835

Closed

Uh oh!

Conversation

spacebear21 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21868383672

Details

💛 - Coveralls

Uh oh!

DanGould commented Jan 27, 2026

Uh oh!

DanGould left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chavic commented Jan 27, 2026

Uh oh!

DanGould commented Jan 27, 2026

Uh oh!

spacebear21 commented Jan 27, 2026

Uh oh!

arminsabouri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arminsabouri commented Jan 27, 2026

Uh oh!

DanGould commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spacebear21 commented Jan 28, 2026

Uh oh!

spacebear21 commented Feb 10, 2026

Uh oh!

benalleng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

spacebear21 commented Jan 21, 2026 •

edited

Loading

coveralls commented Jan 21, 2026 •

edited

Loading

DanGould commented Jan 27, 2026 •

edited

Loading

benalleng left a comment •

edited

Loading