Skip to content

Publish the npm tarball by explicit file path - #1847

Merged
spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:fix-npm-publish-tarball-path
Aug 27, 2026
Merged

spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:fix-npm-publish-tarball-path

Conversation

@spacebear21

Copy link
Copy Markdown
Collaborator

The first javascript release run (payjoin-javascript-0.2.0+payjoin-1.0.0) failed in the publish step: npm parses a relative path containing a slash but no ./ prefix as a GitHub owner/repo shorthand, so npm publish "dist/payjoin-0.2.0.tgz" ran git ls-remote ssh://git@github.com/dist/payjoin-0.2.0.tgz.git and failed on SSH auth without ever contacting the registry. Prefixing ./ disambiguates the argument as a local tarball; reproduced and verified against npm 11.6.2 with npm publish --dry-run both ways.

Since the publish workflow runs at the tagged commit, the payjoin-javascript-0.2.0+payjoin-1.0.0 tag will be recreated on master once this lands.

Disclosure: co-authored by Claude Fable 5

Pull Request Checklist

Please confirm the following before requesting review:

https://claude.ai/code/session_019BcdiyBCQQChuJ3dy7QJwm

npm parses a relative path that contains a slash but no ./ prefix as
a GitHub owner/repo shorthand, so the first javascript release run
executed `git ls-remote ssh://git@github.com/dist/payjoin-0.2.0.tgz`
and failed on SSH auth instead of publishing the local tarball. The
./ prefix disambiguates the argument as a file path; reproduced and
verified against npm 11.6.2 with `npm publish --dry-run`.
@spacebear21
spacebear21 force-pushed the fix-npm-publish-tarball-path branch from 178fa03 to 0b98fa1 Compare August 27, 2026 15:37

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0b98fa1

@caarloshenriq caarloshenriq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@coveralls

coveralls commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 33088858924

Coverage remained the same at 86.719%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16459
Covered Lines: 14273
Line Coverage: 86.72%
Coverage Strength: 343.64 hits per line

💛 - Coveralls

@spacebear21
spacebear21 merged commit 7804f2d into payjoin:master Aug 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants