Update toml edition 2024 - #1874
Merged
Merged
Conversation
benalleng
force-pushed
the
update-toml-edition-2024
branch
from
September 10, 2026 17:06
07420a1 to
5583749
Compare
Collaborator
Coverage Report for CI Build 34613736043Coverage remained the same at 86.646%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
force-pushed
the
update-toml-edition-2024
branch
2 times, most recently
from
September 10, 2026 18:13
a4066f4 to
084ab31
Compare
Collaborator
Author
|
Rebased as there were a few |
benalleng
force-pushed
the
update-toml-edition-2024
branch
2 times, most recently
from
September 10, 2026 18:56
5972fbd to
0624b21
Compare
DanGould
reviewed
Sep 11, 2026
In rust edition 2024 `gen` is a reserved keyword so these methods need to be prefixed with the `r#` raw identifier prefix to pass formatting rules.
In rust edition 2024 if let statements that can be collapsed into a let chain will fail clippy checks. See https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if for details.
benalleng
force-pushed
the
update-toml-edition-2024
branch
from
September 11, 2026 15:02
0624b21 to
95c4afb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the toml editions for the cargo toml files in each crate as I simply did not have a good understanding of how this all worked when I first updated to
1.85.0. By updating the edition we can remove most semver pins as the now defaultresolver = 3will handle this for us.Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.