Skip to content

fix ciao tests - #331

Merged
missinglink merged 2 commits into
masterfrom
fix_ciao_tests
Oct 2, 2015
Merged

fix ciao tests#331
missinglink merged 2 commits into
masterfrom
fix_ciao_tests

Conversation

@missinglink

Copy link
Copy Markdown
Member

cc/ @orangejulius

I noticed a couple oddities when testing the sanitizers groups:

/v1/reverse?point.lat=40.744243&point.lon=-73.990342&boundary.circle.radius=999.9

this one has the sanitized inputs but with a warning that they are not supported:

query: {
  boundary.circle.radius: 999.9,
  boundary.circle.lat: 40.744243,
  boundary.circle.lon: -73.990342
},
warnings: [
  "boundary.circle is currently unsupported"
]

and this one:

/v1/reverse?point.lat=40.744243&point.lon=-73.990342&boundary.circle.radius=foo

has an error regarding something which is not supported:

warnings: [
  "boundary.circle is currently unsupported"
],
errors: [
  "missing param 'boundary.circle.radius'"
],

also I noticed that we no longer support boundary.circle for /reverse, so I commented out some of those assertions, any idea why we chose to do that? It seems like the ideal endpoint to use that type of boundary with? cc/ @riordan

the warning message boundary.circle is currently unsupported sounds like we plan to support it in the future, is that the case?

@orangejulius

Copy link
Copy Markdown
Member

Aww you missed my PR #330

missinglink added a commit that referenced this pull request Oct 2, 2015
@missinglink
missinglink merged commit 38b53e7 into master Oct 2, 2015
@missinglink missinglink mentioned this pull request Oct 8, 2015
@orangejulius
orangejulius deleted the fix_ciao_tests branch May 25, 2016 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants