better population and popularity boosting - #338
Merged
Conversation
Member
Author
|
closes #309 (this PR replaces that branch, which can be closed and deleted in favour of this one) |
Member
Author
|
added 2x new commits to balance queries even more, 2ce249a adds more emphasis to local results and 8ceac4c changes the modifier from now we get the correct top 2 results for this is on the |
Contributor
|
This is awesome! 👍 |
Member
|
💯 |
missinglink
added a commit
that referenced
this pull request
Oct 8, 2015
…osting better population and popularity boosting
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes the
popularityboosting and also addspopulationboosting.originally I thought there was no population info but that was wrong, so now we use that too, which means:
/v1/autocomplete?text=london before: 1) London, United Kingdom 2) East London, EASTERN CAPE 3) New London County, CT 4) London, Modum, Buskerud 5) London, Dr Ruth Segomotsi Mompati District Municipality, North-West after: 1) London, Greater London, United Kingdom 2) London, Middlesex, Ontario 3) London, United Kingdom 4) London, Madison County, OH 5) London, Laurel County, KYalso there were issues with the popularity boost applying to ngram matching, now they both use phrase matching instead, so no more boosting partially matched admin results to the top:
(matching m d and t)
since we are no longer only matching against admin0,admin1 and admin2 this solves the 'San Francisco problem':
... plus much better results all around 🍷