Skip to content

v0.2.1 - #41

Merged
nsheff merged 139 commits into
masterfrom
tximeta
Oct 30, 2020
Merged

v0.2.1#41
nsheff merged 139 commits into
masterfrom
tximeta

Conversation

@stolarczyk

Copy link
Copy Markdown
Member

No description provided.

nsheff and others added 30 commits April 18, 2019 11:21
- add bioconductor config selection method
- add warning when Project provided as an arg
- make a few function private; docs
add multiple methods acting on cascading Config objects; from pipeline interface to output templates
the source (piface and pipeline within piface) info is preserved
- modify getPipelines method, so that it can select the pipelines by protocol
- simplify the getOutFiles function
- make the getOutFiles function return outputs populated only by samples that match the protocol
- docs
- preserve sample names when populating output strings
- make the getOutfiles function return all protocols when none specified
- rename bioconductor section const
@codecov

codecov Bot commented Oct 21, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@70b793a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   72.53%           
=========================================
  Files             ?        3           
  Lines             ?      193           
  Branches          ?        0           
=========================================
  Hits              ?      140           
  Misses            ?       53           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b793a...5008571. Read the comment docs.

@nsheff

nsheff commented Oct 30, 2020

Copy link
Copy Markdown
Contributor

Ok, I'm ready to release this. The tximeta thing is awesome.

We're not passing tests though, is that something you wanted to solve now?

@stolarczyk

Copy link
Copy Markdown
Member Author

We're not passing tests though

yeah, I noticed that. But I was not able to reproduce the linux issue that makes the tests fail -- it is related to some BiocStyle dependency incompatibility. I spent some time trying to solve that but with no luck. This is not a problem for macOS and, surprisingly, for linux tests in Travis.

is that something you wanted to solve now

no, we can solve it in the future, before submitting to Bioconductor

@nsheff
nsheff merged commit 472d80f into master Oct 30, 2020
@nsheff
nsheff deleted the tximeta branch October 30, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants