Skip to content

Release 1.32.7-beta.1 - #2389

Merged
rishigupta1599 merged 1 commit into
masterfrom
release/1.32.7-beta.1
Aug 18, 2026
Merged

Release 1.32.7-beta.1#2389
rishigupta1599 merged 1 commit into
masterfrom
release/1.32.7-beta.1

Conversation

@aryanku-dev

Copy link
Copy Markdown
Contributor

Version bump to 1.32.7-beta.1 — lockstep across all packages.

  • On publishing a GitHub Release, this goes to npm under dist-tag beta.
  • Only version files are touched: lerna.json + packages/**/package.json.

Why not the Create Release PR workflow

That workflow computes the target from lerna.json, which #2377 left at 1.32.6 even though every packages/*/package.json moved to 1.32.7-beta.0 (already published to npm under beta). A prerelease bump would therefore have recomputed 1.32.7-beta.0 and collided with the existing release. This PR sets the version explicitly and realigns lerna.json with the packages.

Next steps: review & merge, then cut the GitHub Release.

Lockstep version bump across all packages (npm dist-tag: beta).

Also realigns lerna.json, which #2377 left at 1.32.6 while every
packages/*/package.json moved to 1.32.7-beta.0.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@aryanku-dev
aryanku-dev requested a review from a team as a code owner August 18, 2026 14:24
@aryanku-dev aryanku-dev added the 🧹 maintenance General maintenance label Aug 18, 2026
@aryanku-dev

Copy link
Copy Markdown
Contributor Author

Claude Code PR Review

PR: #2389Head: a73cdfeReviewers: stack-code-reviewer

Summary

Lerna fixed-mode version bump to 1.32.7-beta.1 across lerna.json and all 18 workspace packages, which also realigns lerna.json with the packages after PR #2377 left it behind at 1.32.6 while every packages/*/package.json moved to 1.32.7-beta.0.

Review Table

Priority Category Check Status Notes
High Security No hardcoded secrets or credentials Pass Diff is version strings only; no tokens, keys, or registry credentials.
High Security Authentication/authorization checks present N/A No auth code in scope.
High Security Input validation and sanitization N/A No input-handling code in scope.
High Security No IDOR — resource ownership validated N/A No resource access code in scope.
High Security No SQL injection (parameterized queries) N/A No database code in scope.
High Correctness Logic is correct, handles edge cases Pass All 18 packages bumped; every internal @percy/* pin equals 1.32.7-beta.1 exactly, so each package resolves siblings from the workspace rather than the registry. lerna.json agrees with the packages.
High Correctness Error handling is explicit, no swallowed exceptions N/A No executable code in scope.
High Correctness No race conditions or concurrency issues N/A No concurrent code in scope.
Medium Testing New code has corresponding tests N/A Release metadata only; no behavior to test.
Medium Testing Error paths and edge cases tested N/A As above.
Medium Testing Existing tests still pass (no regressions) Pass Windows matrix fully green. Test re-run (attempt 3) green across 17/18 legs with @percy/core still executing at review time. Attempt 1's mass cancellation was a transient npm 502 on tr46-0.0.3.tgz in the sdk-utils leg, amplified by the test matrix defaulting to fail-fast: true — unrelated to this diff.
Medium Performance No N+1 queries or unbounded data fetching N/A No query or fetch code in scope.
Medium Performance Long-running tasks use background jobs N/A No task scheduling in scope.
Medium Quality Follows existing codebase patterns Pass Byte-shape matches prior release commits (e7dd935, ec8718b): same field set, same 2-space + trailing-newline formatting, publishConfig.tag correctly left at beta for a prerelease.
Medium Quality Changes are focused (single concern) Pass Exactly 19 files, 64 insertions / 64 deletions, every changed line a version string. No scope creep.
Low Quality Meaningful names, no dead code N/A No code in scope.
Low Quality Comments explain why, not what N/A No comments in scope.
Low Quality No unnecessary dependencies added Pass No dependency added or removed; only existing internal pins re-pointed. yarn.lock correctly untouched — it holds zero @percy/* entries, so workspace packages are symlinked, never lockfile-resolved.

Findings

No Fail rows and no findings at any severity. The reviewer independently verified completeness (all 18 packages), internal @percy/* pin consistency, publishConfig.tag correctness for a prerelease, lerna.json agreement, yarn.lock non-involvement, and absence of scope creep.

Two non-blocking notes carried from the reviewer, neither a defect in this diff:

  • The prior EUNCOMMIT ... M yarn.lock failure that broke three Release runs on the 1.32.7-beta.0 tag was a stale-lockfile issue fixed by b913177, not something this bump must also carry. Confirmed: git diff origin/master origin/release/1.32.7-beta.1 -- yarn.lock is empty.
  • House process — this bump was produced by a scripted edit equivalent to version-bump.yml rather than by the workflow itself, because the workflow computes its target from lerna.json and the stale 1.32.6 there would have recomputed the already-published 1.32.7-beta.0. Merging this PR realigns lerna.json and restores the workflow for future releases.

Raised by other reviewers (not independently confirmed)

@rishigupta1599 submitted an APPROVED review with no body — no concern to confirm or carry.


Verdict: PASS

@rishigupta1599
rishigupta1599 merged commit e23db23 into master Aug 18, 2026
55 of 88 checks passed
@rishigupta1599
rishigupta1599 deleted the release/1.32.7-beta.1 branch August 18, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧹 maintenance General maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants