Skip to content

also load configuration from setup.cfg - #57

Merged
peritus merged 3 commits into
peritus:masterfrom
t-8ch:setup.cfg
Dec 28, 2014
Merged

also load configuration from setup.cfg#57
peritus merged 3 commits into
peritus:masterfrom
t-8ch:setup.cfg

Conversation

@t-8ch

@t-8ch t-8ch commented Sep 22, 2014

Copy link
Copy Markdown
Contributor

Fixes #49

Fixes peritus#49

This patch is optimized for maximum compatability.
@peritus

peritus commented Oct 22, 2014

Copy link
Copy Markdown
Owner

Nice patch!

Note to self: Needs documentation (1 sentence in README should do).

Comment thread tests.py Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should still say .bumpversion.cfg here, just for people who use --help to find out the default.

@t-8ch

t-8ch commented Oct 24, 2014

Copy link
Copy Markdown
Contributor Author

@peritus I pushed a new patch. It is a bit uglier as before but behaves as
following:

  • If --config-file is not passed it tries to use .bumpversion.cfg or
    setup.cfg and falls back to the builtin defaults.
  • If the configfile is explicitly specified and can not be read we error out.
  • It also errors out if the user specified one of the default config files
    explicitly and they are broken. (The implementation of this is, what makes
    the thing a bit ugly)

@ionelmc

ionelmc commented Dec 21, 2014

Copy link
Copy Markdown

@peritus Any chance you gonna merge/release this soon?

@peritus
peritus merged commit 117842b into peritus:master Dec 28, 2014
peritus added a commit that referenced this pull request Dec 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load configuration from setup.cfg

3 participants