feat: api generation with goa - #10
Merged
Merged
Conversation
This commit adds an `api` module that uses Goa to generate HTTP client and server code. The API specification so far is incomplete but does have some of the core entities and operations. Some of the generated examples in the OpenAPI spec are wonky, such as repeating the same example for the `ArrayOf` properties. Hopefully I can fix these in a followup commit.
Closed
cmotyka
approved these changes
Jan 22, 2025
AntTheLimey
added a commit
that referenced
this pull request
Jul 20, 2026
CheckImageExists relied solely on a registry DistributionInspect, so a locally-built image never pushed to a registry (or a private registry without resolvable auth) failed spec validation. Add a local Docker daemon ImageInspectWithRaw fallback: registry first, then local cache, error only if both miss. The two lookups get independent timeout budgets so a slow-failing registry lookup cannot starve the local check of its context. Finding #10 of the ColdFront single-node trial remediation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an
apimodule that uses Goa to generate HTTP client and server code. The API specification so far is incomplete but does have some of the core entities and operations.Some of the generated examples in the OpenAPI spec are wonky, such as repeating the same example for the
ArrayOfproperties. Hopefully I can fix these in a followup commit.All of the code in the
gendirectory is generated based on the spec in thedesigndirectory.