[WIP] Physical to logical replica support

.gitignore

@@ -1,7 +1,8 @@
 results
 regression_output
 tmp_check
-spock_create_subscriber
+/utils/spock_create_subscriber/spock_create_subscriber
+/utils/spock_create_subscriber/.deps/
 .vimrc
 *.o
 *.so

Makefile

@@ -9,6 +9,7 @@ EXTENSION = spock
 PGFILEDESC = "spock - multi-master replication"
 
 MODULES = spock_output
+SUBDIRS = utils/spock_create_subscriber
 
 # Lookup source directory
 vpath % src src/compat/$(PGVER)

docs/creating_subscriber_nodes.md

@@ -0,0 +1,38 @@
+## Creating a Subscriber Node with pg_basebackup
+
+Spock supports creating a subscriber node by cloning the provider with [`pg_basebackup`](https://www.postgresql.org/docs/current/app-pgbasebackup.html) and starting it as a Spock subscriber. Use the `spock_create_subscriber` utility (located in the `bin` directory of your pgEdge platform installation) to register the node.
+
+### Synopsis:
+
+  `spock_create_subscriber [OPTION]...`
+
+**Options**
+
+Specify the following options as needed.
+
+| Option   | Description
+|----------|-------------
+| `-D`, `--pgdata=DIRECTORY` | The `data` directory to be used for new node. This can be either an empty/non-existing directory, or a directory populated using the `pg_basebackup -X stream` command.
+| `--databases`              |  An optional list of databases to replicate.
+| `-n`, `--subscriber-name=NAME` | The name of the newly created subscriber.
+| `--subscriber-dsn=CONNSTR` | A connection string to the newly created subscriber.
+| `--provider-dsn=CONNSTR` | A connection string to the provider.
+| `--replication-sets=SETS` | A comma-separated list of replication set names.
+| `--apply-delay=DELAY` | The apply delay in seconds (by default 0).
+| `--drop-slot-if-exists` | Drop replication slot of conflicting name.
+| `-s`, `--stop` | Stop the server once the initialization is done.
+| `-v` | Increase logging verbosity.
+| `--extra-basebackup-args` | Additional arguments to pass to `pg_basebackup`. Safe options are: `-T`, `-c`, `--xlogdir`/`--waldir`
+| `--text-types` | Transfer all column values as text rather than binary during initial sync. Use this when provider and subscriber differ in endianness or type representation.
+
+**Configuration files overrides**
+
+You can use the following options to override the location of the configuration files.
+
+| Option   | Description
+|----------|-------------
+|`--hba-conf` | path to the new `pg_hba.conf`
+| `--postgresql-conf` | path to the new `postgresql.conf`
+| `--recovery-conf` | path to the template recovery configuration
+
+Unlike `spock.sub_create`'s other data sync options, this method of cloning ignores replication sets and copies all tables on all databases. However, it's often much faster, especially over high-bandwidth connections.

src/spock_fe.c

@@ -226,10 +226,12 @@ appendPQExpBufferConnstrValue(PQExpBuffer buf, const char *str)
 	bool		needquotes;
 
 	/*
-	 * If the string consists entirely of plain ASCII characters, no need to
-	 * quote it. This is quite conservative, but better safe than sorry.
+	 * If the string is one or more plain ASCII characters, no need to quote
+	 * it.  An empty string must default to needing quotes -- an unquoted
+	 * empty value doesn't parse as empty, it swallows the entire next
+	 * "keyword=value" token.
 	 */
-	needquotes = false;
+	needquotes = true;
 	for (s = str; *s; s++)
 	{
 		if (!((*s >= 'a' && *s <= 'z') || (*s >= 'A' && *s <= 'Z') ||
@@ -238,6 +240,7 @@ appendPQExpBufferConnstrValue(PQExpBuffer buf, const char *str)
 			needquotes = true;
 			break;
 		}
+		needquotes = false;
 	}
 
 	if (needquotes)

tests/tap/schedule

@@ -58,10 +58,12 @@ test: 037_wire_format_datestyle
 test: 038_reserved_schema_ddl_guard
 test: 044_apply_change_logging
 test: 045_lsn_from_commit_ts
+test: 048_bidir_join
 # Upgrade schema match test (builds from source, slow):
 #test: 018_upgrade_schema_match
 #
 
 # Regression tests
 test: 103_manager_worker_dboid_race
 test: 105_sub_disable_retransmit_after_disconnect
+