chore: refresh metagame feeds - #1048
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the metagame feeds for Modern, Pioneer, and Standard formats, refreshing decklists and update timestamps. The reviewer identified critical data integrity issues across all updated files, specifically the inclusion of keyword abilities and hallucinated or custom card names in place of valid Magic: The Gathering cards. These errors violate the project's requirement for strict fidelity to the MTG Comprehensive Rules and suggest a failure in the data scraping process.
| { | ||
| "count": 2, | ||
| "name": "Glimpse the Impossible" | ||
| "name": "Flashback" |
There was a problem hiding this comment.
[HIGH] Invalid card name "Flashback" detected in decklist. Why it matters: "Flashback" is a keyword ability, not a card name; its inclusion suggests a parsing error in the scraper (likely misidentifying a text header or keyword as a card). This violates the requirement for strict fidelity to the MTG Comprehensive Rules (CR).
References
- Strict fidelity to the MTG Comprehensive Rules (CR) — every game rule, validation, and computed value matches the CR exactly. (link)
| { | ||
| "count": 1, | ||
| "name": "Unlicensed Hearse" | ||
| "name": "The Legend of Roku" |
There was a problem hiding this comment.
[HIGH] Corrupted card data detected in metagame feed. Why it matters: The feed contains non-existent card names (e.g., "The Legend of Roku", "Thundering Broodwagon", "Formidable Speaker") which appear to be from custom or fan-made sets. This violates the "Strict fidelity to the MTG Comprehensive Rules (CR)" pillar and will cause the engine to fail when processing these decks.
References
- Strict fidelity to the MTG Comprehensive Rules (CR) — every game rule, validation, and computed value matches the CR exactly. (link)
| { | ||
| "count": 1, | ||
| "name": "Kutzil, Malamet Exemplar" | ||
| "name": "Ba Sing Se" |
There was a problem hiding this comment.
[HIGH] Hallucinated card names in Standard metagame feed. Why it matters: Card names like "Ba Sing Se", "Gran-Gran", and "Iroh's Demonstration" are not valid Magic: The Gathering cards. This indicates a systemic failure in the automated scraper or an incorrect data source, breaking the engine's ability to provide accurate metagame state.
References
- Strict fidelity to the MTG Comprehensive Rules (CR) — every game rule, validation, and computed value matches the CR exactly. (link)
Automated daily metagame feed refresh from MTGGoldfish.