Fix #863: tag granted Suspend casts via off-zone-aware keyword query

[mike-theDude]

Summary

Fixes #863. Jhoira of the Ghitu (and The Tenth Doctor) grant Suspend with time counters to an exiled card via a permanent-duration AddKeyword { Suspend } continuous effect. The off-zone synthesis path correctly produced the upkeep counter-ticking and the last-counter cast trigger, but the cast itself misrouted to CastingVariant::Normal because two predicates in crates/engine/src/game/casting.rs (casting_variant_candidates and is_suspend_cast inside prepare_spell_cast_with_variant_override_inner) read obj.keywords directly. evaluate_layers does not populate obj.keywords for exile-zone objects, so runtime-granted Suspend was invisible and CR 702.62a's "if you cast a creature spell this way, it gains haste" transient effect was never installed.

Both predicates now query super::keywords::object_has_effective_keyword_kind(state, object_id, KeywordKind::Suspend) — the same off-zone-aware helper Escape, Flashback, Retrace, and Aftermath already use in this file. This removes a printed-Suspend-only special case rather than adding a new one; Suspend now follows the canonical off-zone keyword pattern used by every other alternative-cost keyword in casting.rs.

Files changed

• crates/engine/src/game/casting.rs
• crates/engine/src/parser/oracle_effect/mod.rs

CR references

• CR 702.62a — Suspend; "If you cast a creature spell this way, it gains haste."
• CR 604.1 — Static abilities granting keywords (runtime keyword grants).

Track

Developer

LLM

Model: Claude Opus 4.7
Thinking: medium

Verification

• cargo fmt --all — clean
• ./scripts/check-parser-combinators.sh — clean
• cargo clippy-strict — clean (qa-tester)
• cargo test -p engine — 9332 pass / 0 fail (qa-tester)
• New tests:
  • jhoira_granted_suspend_last_counter_cast_tags_suspend_variant — discriminator: asserts prepare_spell_cast_with_variant_override returns CastingVariant::Suspend for the granted-Suspend exile cast (fails as Normal without the fix).
  • jhoira_granted_suspend_creature_cast_gains_haste — behavioral: drives a real CastSpell + stack::resolve_top on a creature, asserts effective Haste keyword is installed (CR 702.62a final sentence).

Scope Expansion

None.

Validation Failures

None.

CI Failures

None.

Follow-up (not bundled here)

• has_madness at casting.rs:1692-1698 reads obj.keywords the same way and may have the same off-zone-grant invisibility bug for Madness — separate issue recommended.
• Parser advisory comment added at oracle_effect/mod.rs flags that a future CostPaidObjectLacksKeyword variant will be needed when a card uses "if it doesn't have X" against the cost-paid object (no current card requires it).

[gemini-code-assist]

Code Review

This pull request updates the Suspend keyword detection in crates/engine/src/game/casting.rs to use object_has_effective_keyword_kind instead of querying obj.keywords directly. This ensures that Suspend granted at runtime (e.g., by Jhoira of the Ghitu) is correctly recognized from off-zone sets, and adds two comprehensive unit tests to verify this behavior. The feedback identifies a violation of repository rule R6, where a rules-touching comment lacks the mandatory CR <number>: <description> annotation format.