Center mana pips, wire AI bracket filter to engine estimate, lean test i18n, collapsible groups

[matthewevans]

Net change over main is the 13 files below (the prior cEDH commits on this branch already landed on main via squash).

• Mana pips (ManaCostPips.tsx): flex-center the glyph in its circle — the inline-block baseline pushed it ~5px low (spilling past the bottom). Normalize lg padding now that the baseline-compensation hack is moot.
• AI bracket filter (aiDeckCatalog.ts + test): resolve a Commander candidate's bracket from the engine's computed BracketEstimate when no explicit tag exists, so the filter stops collapsing every selection to "Random (0)". Explicit tags win; non-Commander formats skip estimation.
• Test i18n (test-setup.ts): register a lean English-only i18next instead of importing the app i18n module (which eager-loaded 49 catalogs + a store subscription per test file under worker isolation) — ~54% less per-file setup time.
• Collapsible permanent groups (BattlefieldRow.tsx, GroupedPermanent.tsx, 7× locale game.json): a count badge toggles an expanded group back to stacked; collapseGroup added across all 7 locales to satisfy the key-parity gate.

[gemini-code-assist]

Code Review

This pull request introduces table-wide cEDH mode support, featuring a dedicated cEDH toggle, hand-curated bundled cEDH decks, and a typed bracket-violation error when non-cEDH decks are brought to a cEDH table. It also adds a cEDH combo-recognition layer with a ComboLinePolicy to boost actions progressing reachable combos, alongside a CedhKeepablesMulligan policy for aggressive mulligans. Additionally, a collapse button is added to grouped permanents. Feedback highlights a critical compilation failure due to a missing invalidate_player_features method on AiSession. It also recommends gating the cEDH mode and toggle to the Commander format to prevent initialization failures, and expanding the touch target of the new collapse button to at least 44px for mobile friendliness.

I am having trouble creating individual review comments. Click here to see my feedback.

crates/phase-ai/src/session.rs (107)

[CRITICAL] Missing invalidate_player_features method on AiSession causes a compilation failure because it is called in crates/phase-ai/src/search.rs to refresh features when the AI's bracket tier is not Core.

    pub fn invalidate_player_features(&mut self, player: PlayerId) {
        self.features.remove(&player);
        self.plan.remove(&player);
    }

    pub fn ensure_player_features(

client/src/pages/GameSetupPage.tsx (167)

[HIGH] Gating cedhMode on selectedFormat === "Commander" is necessary to prevent game-breaking initialization failures when playing non-Commander formats if cedhMode was left enabled in the persisted preferences.

    const cedhMode = prefs.cedhMode && selectedFormat === "Commander";

client/src/providers/GameProvider.tsx (312-314)

[HIGH] Gating cedhMode on formatConfig?.format === "Commander" in buildLocalAiDeckList is necessary to prevent game-breaking initialization failures when playing non-Commander formats if cedhMode was left enabled in the persisted preferences.

  const effectiveCedhMode = cedhMode && formatConfig?.format === "Commander";
  const aiDifficulties = picks.map((_, i) =>
    effectiveAiDifficulty(aiSeats[i]?.difficulty ?? "Medium", effectiveCedhMode),
  );

client/src/components/board/GroupedPermanent.tsx (180)

[MEDIUM] The collapse button has a size of h-5 w-5 (20px), which violates the style guide rule requiring touch targets to be at least 44pt/px for mobile/touch friendliness. We can expand the touch target using a pseudo-element without changing the visual size.

          className="absolute left-1 top-1 z-30 flex h-5 w-5 items-center justify-center rounded-full bg-black/80 text-[10px] font-bold text-white ring-1 ring-gray-500 transition-colors hover:bg-black before:absolute before:-inset-3"

References

1. Mobile / touch: touch targets ≥ 44pt; :hover-only state breaks on mobile and needs a touch-equivalent. ^(link)

client/src/components/menu/AiOpponentConfig.tsx (140-161)

[MEDIUM] The table-wide cEDH toggle should only be rendered when selectedFormat === "Commander" to avoid confusing users when playing non-Commander formats.

      {selectedFormat === "Commander" && (
        <div className="flex items-center justify-between gap-3 rounded-lg border border-rose-500/25 bg-rose-500/5 px-3 py-2">
          <div className="flex min-w-0 flex-col">
            <span className="text-xs font-semibold text-rose-200">{t("aiOpponent.cedhToggle.label")}</span>
            <span className="text-[10px] text-slate-400">{t("aiOpponent.cedhToggle.hint")}</span>
          </div>
          <button
            type="button"
            role="switch"
            aria-checked={cedhMode}
            aria-label={t("aiOpponent.cedhToggle.label")}
            onClick={() => setCedhMode(!cedhMode)}
            className={`relative inline-flex h-6 w-11 shrink-0 items-center rounded-full transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-rose-300/60 ${
              cedhMode ? "bg-rose-500" : "bg-white/15"
            }`}
          >
            <span
              className={`inline-block h-5 w-5 transform rounded-full bg-white transition-transform ${
                cedhMode ? "translate-x-5" : "translate-x-0.5"
              }`}
            />
          </button>
        </div>
      )}

[matthewevans]

Triage of the Gemini review — note this PR's net diff over main is only the 13 frontend files; the cEDH commits Gemini summarized already landed on main via an earlier squash, so most findings are out of scope here:

• [CRITICAL] session.rs missing invalidate_player_features — false alarm. The method exists (crates/phase-ai/src/session.rs:130) and is called (search.rs:1127); the tree compiles. Gemini analyzed a pre-squash state. Not in this PR's diff.
• [HIGH] GameSetupPage.tsx / GameProvider.tsx cedhMode gating and [MEDIUM] AiOpponentConfig.tsx toggle gating — these files are not in this PR's net diff (cEDH code already on main). If the non-Commander gating gap is real, it belongs in a follow-up against main, not here.
• [MEDIUM] GroupedPermanent.tsx collapse button ≥44px touch target — in scope, but declined as a one-off. Every board badge is 20px (h-5 w-5): the sibling expand badge at GroupedPermanent.tsx:293 (same left-1 top-1 anchor, collapsed mode) and PermanentCard.tsx:729. This collapse button deliberately mirrors the expand badge. Adding an invisible 44px halo to only one of a matched pair is inconsistent; the ≥44px rule should be a single consistent pass across all board badges as a follow-up.