chore: update coverage stats and badges - #14
Merged
Conversation
matthewevans
enabled auto-merge (squash)
April 8, 2026 16:06
matthewevans
added a commit
to minion1227/phase
that referenced
this pull request
Jul 13, 2026
…rkspace (phase-rs#5712) Gate (C) in check-engine-authorities.sh froze the `ReplacementEvent::Draw` producer surface by scanning 3 named crates (engine, engine-wasm, mtgish-import) of a 13-crate workspace. That list was never a decision — it was a workaround for a scanner ceiling: `strip_noncode` had no branch for Rust raw strings, so a workspace-wide scan died on `crates/draft-wasm/src/suggest.rs:437: brace tracking desynced`. phase-rs#5704 taught the scanner raw strings, so the scope can now be what it always claimed to be. SCOPES is now globbed (`crates/*/src`), not enumerated. A hand-written tuple is a list that goes stale the moment crate phase-rs#14 lands — which is exactly how this census went wrong twice before (v1 froze 6 producers while a 7th was live in mtgish-import). The glob cannot go stale, and because the producer baseline is an exact-match gate, a Draw producer minted in a brand-new crate fails the build on the day it arrives. Population: 3 -> 13 crates, 469 -> 701 .rs files scanned (+232). Producers: 7 rows -> 7 rows. ZERO new producers. `ReplacementEvent::Draw` occurs in exactly two crates (engine, mtgish-import), so no producer was missing a CR 121.2 scope decision and no row's scope moved. The baseline diff is header prose only. The zero is not vacuous. phase-ai builds `ReplacementDefinition`s with the very same constructor and struct-literal idioms this census matches (AddCounter, Moved, ChangeZone) — just never with `Draw`. And a synthetic `Draw` producer planted in phase-ai turns the widened gate RED (`ADDED crates/phase-ai/src/cast_facts.rs scratch_t59_synthetic_draw_producer constructor 1`) while the OLD 3-crate scope reports `PASS (7 rows)` — the widening is what catches it. Boundary, named rather than implied: the two Rust trees Cargo excludes from the workspace (`client/src-tauri`, `lobby-worker/broker-wasm`; 4 .rs files) are not scanned. Neither mentions `ReplacementEvent`. `client/src-tauri` also grows a gitignored `target/` on any local Tauri build, which an rglob would descend into — making the scanned population depend on whether a developer had run one. CR 121.2 (grep-verified, docs/MagicCompRules.txt:1144): cards may only be drawn one at a time. CR 121.2a (:1146): an instruction to draw multiple cards can be modified by replacement effects that refer to the number of cards drawn. Co-authored-by: matthewevans <matthewevans@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated update of README coverage badges from latest card data.