fix(engine): scope 'is renowned' condition to event subject vs source (CR 702.112) - #2782
Merged
Merged
Conversation
… (CR 702.112)
Parameterize TriggerCondition::SourceIsRenowned into
IsRenowned { subject: RenownSubject } so that 'if it's renowned' reads the
event-subject creature's renowned designation (CR 702.112b) while
'if ~ is renowned' keeps reading the ability's own source (CR 702.112a).
Previously both Oracle phrases collapsed onto SourceIsRenowned, which always
read the trigger source -- wrong for any payoff that cares about a different
(triggering/event) creature's renowned state.
The EventSubject arm reuses the existing extract_source_from_event resolver
(the same building block that resolves TargetFilter::TriggeringSource), with
an .or(source_id) fallback for the SelfRef-shaped case. RenownSubject is a new
2-variant enum (no existing source-vs-event-subject selector to reuse).
Updates all consumers: parser table, eval, synthesis (Renown's own
intervening-if -> Source x3), and the mtgish-import converter (-> Source).
Regenerates the valeron wardens fixture entry for the new serde shape.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameterize TriggerCondition::SourceIsRenowned into
IsRenowned { subject: RenownSubject } so that 'if it's renowned' reads the
event-subject creature's renowned designation (CR 702.112b) while
'if ~ is renowned' keeps reading the ability's own source (CR 702.112a).
Previously both Oracle phrases collapsed onto SourceIsRenowned, which always
read the trigger source -- wrong for any payoff that cares about a different
(triggering/event) creature's renowned state.
The EventSubject arm reuses the existing extract_source_from_event resolver
(the same building block that resolves TargetFilter::TriggeringSource), with
an .or(source_id) fallback for the SelfRef-shaped case. RenownSubject is a new
2-variant enum (no existing source-vs-event-subject selector to reuse).
Updates all consumers: parser table, eval, synthesis (Renown's own
intervening-if -> Source x3), and the mtgish-import converter (-> Source).
Regenerates the valeron wardens fixture entry for the new serde shape.