test(engine): re-freeze anaphoric allowlist at 166 (crumble/sly spy/solitude reclassified) - #3009
Conversation
…olitude reclassified) The ParentTargetController routing fix (#2741) lets the anaphoric rebind resolve 'its' to Target (the destroyed/exiled object, CR 608.2c) in 'that X's controller gains life equal to its <stat>' for Crumble and Solitude, and the parser-grammar consolidation (#2802) reshaped Sly Spy's variant parse — dropping all three out of ObjectScope::Anaphoric and the frozen count 169 -> 166. The engine reclassification landed in #2741/#2802/ #2803; this re-freezes the card-data drift guard to match (the guard self-skips in CI for lack of client card-data, so it only goes red in local Tilt test-engine — verified green here at 166).
There was a problem hiding this comment.
Code Review
This pull request updates the anaphoric_scope_allowlist_guard.rs integration test to reflect a reduction in the number of cards retaining ObjectScope::Anaphoric from 169 to 166. Specifically, 'crumble', 'sly spy', and 'solitude' were removed from the ANAPHORIC_SCOPE_CARDS list. The test assertions and accompanying comments were updated to explain that this change is due to the ParentTargetController routing fix (#2741) and the parser-grammar consolidation (PR #2802). There are no review comments to address, and the changes are correct and well-documented. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The ParentTargetController routing fix (#2741) lets the anaphoric rebind
resolve 'its' to Target (the destroyed/exiled object, CR 608.2c) in
'that X's controller gains life equal to its ' for Crumble and
Solitude, and the parser-grammar consolidation (#2802) reshaped Sly Spy's
variant parse — dropping all three out of ObjectScope::Anaphoric and the
frozen count 169 -> 166. The engine reclassification landed in #2741/#2802/
#2803; this re-freezes the card-data drift guard to match (the guard
self-skips in CI for lack of client card-data, so it only goes red in local
Tilt test-engine — verified green here at 166).