Skip to content

Add Unravel - #3620

Closed
jason020818 wants to merge 1 commit into
phase-rs:mainfrom
jason020818:card/unravel
Closed

Add Unravel#3620
jason020818 wants to merge 1 commit into
phase-rs:mainfrom
jason020818:card/unravel

Conversation

@jason020818

Copy link
Copy Markdown
Contributor

Summary

Adds engine support for Unravel.

Files changed

  • crates/engine/src/parser/oracle_effect/conditions.rs
  • crates/engine/tests/integration/main.rs
  • crates/engine/tests/integration/unravel_counter_mana_value.rs

CR references

CR 118.9 (mana spent vs mana value), CR 701.59a

Track

Developer

LLM

Model: claude-sonnet-4-6
Thinking: high
Tier: Standard

Gate A

./scripts/check-parser-combinators.sh — clean (exit 0)

Anchored on

  • crates/engine/src/parser/oracle_effect/conditions.rs — existing conditional spell-effect parsers using parse_*_condition
  • crates/engine/tests/integration/ — integration test pattern for counter + conditional draw cards

Verification

  • ./scripts/check-parser-combinators.sh — clean
  • cargo test -p engine --test integration unravel_counter_mana_value — 1 pass / 0 fail

Scope Expansion

None.

Validation Failures

None.

CI Failures

None.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@matthewevans

Copy link
Copy Markdown
Member

Superseded by #3618, which just merged — your Unravel parser is in main with your authorship preserved (the commit is cherry-picked under your name), plus the cast→resolve runtime test the bar requires (it asserts the draw fires only when mana spent < mana value, and fails on revert). The card is live. Closing this as superseded; thank you for the parser work. (The AST-shape-only test here was the same gap that closed #3573 — the runtime test was what it needed.)

@matthewevans matthewevans added the enhancement New feature or request label Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants