Skip to content

fix(parser): optional targeting for "attach any number of target" trigger (Super-Soldier Serum) - #4606

Merged
matthewevans merged 1 commit into
mainfrom
ship/attach-any-number-optional-targeting
Jun 29, 2026
Merged

fix(parser): optional targeting for "attach any number of target" trigger (Super-Soldier Serum)#4606
matthewevans merged 1 commit into
mainfrom
ship/attach-any-number-optional-targeting

Conversation

@matthewevans

Copy link
Copy Markdown
Member

"Whenever enchanted creature attacks or blocks, attach any number of target
Equipment you control to it" forced a mandatory Equipment target, softlocking
when every Equipment was already attached (no way to decline).

The trigger lowering only surfaced optional_targeting when the body contained
the literal "up to one"; extend the detector to "any number of target" so
the variable-count-down-to-zero target (CR 601.2c) yields an optional slot and
a decline action.

…gger (Super-Soldier Serum)

"Whenever enchanted creature attacks or blocks, attach any number of target
Equipment you control to it" forced a mandatory Equipment target, softlocking
when every Equipment was already attached (no way to decline).

The trigger lowering only surfaced optional_targeting when the body contained
the literal "up to one"; extend the detector to "any number of target" so
the variable-count-down-to-zero target (CR 601.2c) yields an optional slot and
a decline action.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@matthewevans
matthewevans enabled auto-merge June 29, 2026 18:45
@matthewevans
matthewevans added this pull request to the merge queue Jun 29, 2026
@github-actions

Copy link
Copy Markdown

Parse changes introduced by this PR · 49 card(s), 24 signature(s) (baseline: main 4a386c16a758)

8 card(s) · ability/DealDamage · field targeting: optional (up to)

Examples: Bogardan Hellkite, Case of the Market Melee, Dragonlord Atarka (+5 more)

6 card(s) · ability/ChangeZone · field targeting: optional (up to)

Examples: Brago, King Eternal, Herald of the Forgotten, Iname, Life Aspect (+3 more)

3 card(s) · ability/Discard · field targeting: optional (up to)

Examples: Hollow Marauder, Tinybones Joins Up, Your Plans Mean Nothing

3 card(s) · ability/Mill · field targeting: optional (up to)

Examples: Court of Cunning, Memory Vampire, Tinybones Joins Up

3 card(s) · ability/PayCost · field targeting: optional (up to)

Examples: Fire Lord Sozin, Numa, Joraga Chieftain, The Thing

3 card(s) · ability/PutCounter · field targeting: optional (up to)

Examples: Jugan, the Rising Star, Quirion Beastcaller, Verdurous Gearhulk

3 card(s) · ability/PutCounterAll · field targeting: optional (up to)

Examples: Filigree Vector, Liege of the Tangle, Sweet-Gum Recluse

3 card(s) · ability/TargetOnly · field targeting: optional (up to)

Examples: Loaming Shaman, Portal Manipulator, Sparkshaper Visionary

2 card(s) · ability/Attach · field targeting: optional (up to)

Examples: Armory Automaton, Super-Soldier Serum

2 card(s) · ability/Draw · field targeting: optional (up to)

Examples: Chancellor of the Mulligan, Communal Brewing

2 card(s) · ability/turn · field targeting: optional (up to)

Examples: Illithid Harvester, Weaver of Lies

1 card(s) · ability/ChangeZone · field target: triggering sourceparent target

Examples: Iname, Life Aspect

1 card(s) · ability/Destroy · field targeting: optional (up to)

Examples: Rampaging Yao Guai

1 card(s) · ability/Double · field targeting: optional (up to)

Examples: Deepglow Skate

1 card(s) · ability/GiveControl · field targeting: optional (up to)

Examples: Coveted Falcon

1 card(s) · ability/PreventDamage · field targeting: optional (up to)

Examples: Angel of Salvation

1 card(s) · ability/RemoveCounter · field targeting: optional (up to)

Examples: Vhal, Scholar of Tactics

1 card(s) · ability/RollDie · field targeting: optional (up to)

Examples: Ancient Brass Dragon

1 card(s) · ability/Sacrifice · field targeting: optional (up to)

Examples: Kuldotha Flamefiend

1 card(s) · ability/SwitchPT · field targeting: optional (up to)

Examples: Inversion Behemoth

1 card(s) · ability/Token · field targeting: optional (up to)

Examples: Lair of the Ashen Idol

1 card(s) · ability/base power 3, base toughness 3, add type artifact, add type creature · field targeting: optional (up to)

Examples: Depthshaker Titan

1 card(s) · ability/draw · field targeting: optional (up to)

Examples: Curse of Surveillance

1 card(s) · ability/its · field targeting: optional (up to)

Examples: Grand Ossuary

Merged via the queue into main with commit fec82e6 Jun 29, 2026
11 checks passed
@matthewevans
matthewevans deleted the ship/attach-any-number-optional-targeting branch June 29, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant