feat: support Ghyrson Starn damage trigger - #5090
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements support for Ghyrson-style non-target damage ('that permanent or player') in accordance with CR 115.10a, CR 120.1, and CR 120.3. It introduces parse_damage_event_target_recipient to parse these mixed recipients during trigger resolution and updates DealDamage to resolve EventTarget using the triggering event's target. The review feedback suggests refactoring the helper function parse_damage_event_target_recipient to return Option<(TargetFilter, &str)> instead of Option<(&str, TargetFilter)> to maintain consistency with other event-context parsing helpers in the codebase, along with updating its call sites.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
9bb1575 to
17c1e63
Compare
Parse changes introduced by this PR · 5 card(s), 3 signature(s) (baseline: main
|
17c1e63 to
af7530f
Compare
No description provided.