Skip to content

feat: support Ghyrson Starn damage trigger - #5090

Merged
matthewevans merged 1 commit into
mainfrom
ship/feat-support-Ghyrson-Starn-damage-trigger
Jul 4, 2026
Merged

feat: support Ghyrson Starn damage trigger#5090
matthewevans merged 1 commit into
mainfrom
ship/feat-support-Ghyrson-Starn-damage-trigger

Conversation

@matthewevans

Copy link
Copy Markdown
Member

No description provided.

@matthewevans
matthewevans enabled auto-merge July 4, 2026 15:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements support for Ghyrson-style non-target damage ('that permanent or player') in accordance with CR 115.10a, CR 120.1, and CR 120.3. It introduces parse_damage_event_target_recipient to parse these mixed recipients during trigger resolution and updates DealDamage to resolve EventTarget using the triggering event's target. The review feedback suggests refactoring the helper function parse_damage_event_target_recipient to return Option<(TargetFilter, &str)> instead of Option<(&str, TargetFilter)> to maintain consistency with other event-context parsing helpers in the codebase, along with updating its call sites.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread crates/engine/src/parser/oracle_effect/lower.rs
Comment thread crates/engine/src/parser/oracle_effect/lower.rs Outdated
Comment thread crates/engine/src/parser/oracle_effect/lower.rs Outdated
@matthewevans
matthewevans force-pushed the ship/feat-support-Ghyrson-Starn-damage-trigger branch from 9bb1575 to 17c1e63 Compare July 4, 2026 16:03
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Parse changes introduced by this PR · 5 card(s), 3 signature(s) (baseline: main 4c0ac54f5a9c)

4 card(s) · ability/DealDamage · field target: triggering sourceparent target or player

Examples: Blast of Genius, Erratic Explosion, Explosive Revelation (+1 more)

1 card(s) · trigger/DamageDone · added: DamageDone (active in=battlefield, valid source=another you)

Examples: Ghyrson Starn, Kelermorph

1 card(s) · trigger/Whenever another source you control deals exactly 1 damage to a permanent or pl… · removed: Whenever another source you control deals exactly 1 damage to a permanent or player (active in=battlefield)

Examples: Ghyrson Starn, Kelermorph

@matthewevans
matthewevans force-pushed the ship/feat-support-Ghyrson-Starn-damage-trigger branch from 17c1e63 to af7530f Compare July 4, 2026 16:49
@matthewevans
matthewevans added this pull request to the merge queue Jul 4, 2026
Merged via the queue into main with commit cf7cd7c Jul 4, 2026
11 checks passed
@matthewevans
matthewevans deleted the ship/feat-support-Ghyrson-Starn-damage-trigger branch July 4, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant