docs(skills): fix two surviving CR 614.16 miscites for as-enters choices - #5818
Conversation
CR 614.16 is the token/counter-creation replacement rule. As-enters effects are CR 614.1c; the choice-before-entering timing is CR 614.12a (both grep-verified against docs/MagicCompRules.txt). PR #5816 corrected one instance of this miscite but these two predated it in a different format.
There was a problem hiding this comment.
Code Review
This pull request updates the Magic Comprehensive Rules (CR) citations in the replacement effect skill documentation (SKILL.md), correcting references to "as enters" choices to use CR 614.1c + 614.12a and CR 614.12a instead of CR 614.16. The review feedback suggests extending this correction to line 104 for consistency across the document, ensuring all references to these rules are fully and accurately cited.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - Delegates everything else to `effects::resolve_ability_chain()`, so any `AbilityDefinition` variant is supported as a follow-up — not just a hand-picked pair. | ||
|
|
||
| **For effects that must happen *before* the zone change** (like "choose a basic land type" — CR 614.16), see Interactive Replacements below. Those pause the pipeline mid-flight rather than using the post-delivery lifecycle. | ||
| **For effects that must happen *before* the zone change** (like "choose a basic land type" — CR 614.12a), see Interactive Replacements below. Those pause the pipeline mid-flight rather than using the post-delivery lifecycle. |
There was a problem hiding this comment.
For consistency with the main "Interactive Replacements" section (line 202) and the table summary (line 22), consider citing both CR 614.1c and CR 614.12a here. CR 614.1c establishes that "as enters" effects are replacement effects, which is the foundation for the choice timing rule in CR 614.12a that this sentence highlights.
| **For effects that must happen *before* the zone change** (like "choose a basic land type" — CR 614.12a), see Interactive Replacements below. Those pause the pipeline mid-flight rather than using the post-delivery lifecycle. | |
| **For effects that must happen *before* the zone change** (like "choose a basic land type" — CR 614.1c + 614.12a), see Interactive Replacements below. Those pause the pipeline mid-flight rather than using the post-delivery lifecycle. |
CR 614.16 is the token/counter-creation replacement rule. As-enters effects
are CR 614.1c; the choice-before-entering timing is CR 614.12a (both
grep-verified against docs/MagicCompRules.txt). PR #5816 corrected one
instance of this miscite but these two predated it in a different format.