Skip to content

fix(engine): resolve mass zone move total damage - #7263

Closed
matthewevans wants to merge 15 commits into
active/issue-6822-draw-bookkeepingfrom
fix/issue-7046-mass-zone-count
Closed

fix(engine): resolve mass zone move total damage#7263
matthewevans wants to merge 15 commits into
active/issue-6822-draw-bookkeepingfrom
fix/issue-7046-mass-zone-count

Conversation

@matthewevans

@matthewevans matthewevans commented Aug 12, 2026

Copy link
Copy Markdown
Member

Fixes #7046.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d0bf5a1-6ec0-4bc7-98a4-ba8718db8cdb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans marked this pull request as ready for review August 12, 2026 16:38
@matthewevans
fix(parser): support Harsh Mentor ability triggers (#7264)
61e79ae 
* fix(parser): parse typed ability activation sources

* test(engine): pass priority before opponent mana activation

* test(engine): isolate Harsh Mentor activation cases

* test(engine): pass priority to opponent activator

* test(engine): assert Harsh Mentor source zone

* test(engine): keep Harsh Mentor coverage parser-scoped

---------

Co-authored-by: matthewevans <matthewevans@users.noreply.github.com>
Base automatically changed from fix/issue-7100-tracked-set-pin to active/issue-7136-mana-journal-stack August 12, 2026 16:38
@matthewevans
fix(wasm): serialize legal action maps with string keys (#7265)
2173a18 
* fix(parser): parse typed ability activation sources

* fix(wasm): serialize legal action maps with string keys

* fix(engine): retain trigger-bound spell history (#7267)

Co-authored-by: matthewevans <matthewevans@users.noreply.github.com>

---------

Co-authored-by: matthewevans <matthewevans@users.noreply.github.com>
Base automatically changed from active/issue-7136-mana-journal-stack to active/issue-7134-mana-replacement-stack August 12, 2026 16:39
Base automatically changed from active/issue-7134-mana-replacement-stack to active/issue-7234-keyword-payloads August 12, 2026 16:42
Base automatically changed from active/issue-7234-keyword-payloads to active/issue-6822-draw-bookkeeping August 12, 2026 16:47
@matthewevans

matthewevans commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Closing as superseded: #7046 was fixed by merged #7277 (69ce21a8ec), and the issue was closed with the Valakut Exploration regression coverage documented there. This branch remains a conflicted historical stack and includes unrelated changes beyond its stated Fixes #7046 scope, so rebasing it would duplicate the landed fix rather than preserve unique work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@matthewevans