Skip to content

test(engine): cover Serra reanimation choice - #7314

Merged
matthewevans merged 1 commit into
mainfrom
ship/test-engine-cover-serra-reanimation-choice
Aug 12, 2026
Merged

test(engine): cover Serra reanimation choice#7314
matthewevans merged 1 commit into
mainfrom
ship/test-engine-cover-serra-reanimation-choice

Conversation

@matthewevans

@matthewevans matthewevans commented Aug 12, 2026

Copy link
Copy Markdown
Member

Adds a cast-pipeline regression for #6769: returning Serra’s Emissary from a graveyard must surface its engine-owned card-type choice, bind that choice to the entering permanent, and retain the selected type.

Summary by CodeRabbit

  • Bug Fixes
    • Added coverage for Serra’s Emissary reanimation, including the card-type selection prompt.
    • Verified that choosing Artifact correctly applies to the reanimated creature as it enters the battlefield.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c5cd213d-862d-4f1f-8b99-cd1a3df1eaa3

📥 Commits

Reviewing files that changed from the base of the PR and between 479ad39 and a9332c8.

📒 Files selected for processing (2)
  • crates/engine/tests/integration/issue_6769_serras_emissary_reanimation.rs
  • crates/engine/tests/integration/main.rs

📝 Walkthrough

Walkthrough

Added an integration regression test for Serra’s Emissary reanimation. The test validates the card-type choice prompt, submits Artifact, resolves the stack, and verifies the creature’s chosen type.

Changes

Serra’s Emissary regression test

Layer / File(s) Summary
Reanimation choice validation
crates/engine/tests/integration/issue_6769_serras_emissary_reanimation.rs, crates/engine/tests/integration/main.rs
The test validates the choice prompt and source, submits Artifact, resolves the stack, and verifies Serra’s Emissary enters the battlefield with the chosen type. The integration module is registered in the test binary.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to a9332

This change adds focused regression coverage for Serra’s reanimation choice behavior without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

Suggested labels: test

Suggested reviewers: jacobwoodson

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies an engine test for Serra reanimation and the associated choice, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ship/test-engine-cover-serra-reanimation-choice

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit 62f33f5 Aug 12, 2026
15 checks passed
@matthewevans
matthewevans deleted the ship/test-engine-cover-serra-reanimation-choice branch August 12, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant