Skip to content

Improve secret input masking #266

Description

@rohan-chaturvedi

Is your feature request related to a problem?

Currently, input masking is handled by the browser by leveraging the html input type="password" attribute. Which this handles masking well, it introduces a few problems

  • The browser prompts the user to "Save this password" when editing secrets. (Browser specific workarounds to block this exist in some cases but are not ideal)
  • The masking looks different on different browsers
  • Masking very large, or multi line values is sub-optimal

Suggested approach

Use a password font such as this one to mask inputs.

Describe alternatives you've considered

Manually replacing masked characters with * or • symbols. While this masks characters, it creates several other issues such as managing the value vs displayValue of inputs, removing the ability to manually copy values, etc

Additional context

Alternative approaches are welcome

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestfosshackIssues for FOSS Hack 2024frontendChange in frontend code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions