Repository navigation
Document boolean support for allowed_classes in unserialize - #4768
Merged
Merged
Conversation
ImperialCrise
commented
Jul 9, 2025
Contributor
- In appendices/migration84/incompatible.xml, update the description of the allowed_classes option to indicate it may be an array of class names or at boolean.
- In reference/var/functions/unserialize.xml, clarify that unserialize() throws TypeError and ValueError if options.allowed_classes is not an array or boolean.
Contributor
Author
|
This stems from the issue that arose because the documentation wasn’t clear: |
PhilDaiguille
approved these changes
Jul 11, 2025
lacatoire
reviewed
Feb 2, 2026
lacatoire
approved these changes
Feb 2, 2026
Member
|
LGTM |
lacatoire
reviewed
Aug 19, 2026
lacatoire
reviewed
Aug 19, 2026
lacatoire
reviewed
Aug 19, 2026
lacatoire
reviewed
Aug 19, 2026
- In appendices/migration84/incompatible.xml, update the description of the allowed_classes option to indicate it may be an array of class names or at boolean. - In reference/var/functions/unserialize.xml, clarify that unserialize() throws TypeError and ValueError if options.allowed_classes is not an array or boolean.
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
Member
|
@ImperialCrise I rebased your branch onto current master. The CI failure had nothing to do with your changes: doc-en moved its DTD entities into entities/ and the workflow builds with doc-base at master. Thanks for your contribution. |
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.