Skip to content

mb_*code_numericentity Clarify the ValueError conditions #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordikroon merged 7 commits into from
Sep 1, 2026
Merged

mb_*code_numericentity Clarify the ValueError conditions #4852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e6ec6f
mb-decode-numericentity.xml Clarify the ValueError conditions
mmalferov Aug 28, 2025
11d2631
mb-encode-numericentity.xml Clarify the ValueError conditions
mmalferov Aug 28, 2025
31e3faf
Update mb-encode-numericentity.xml
mmalferov Aug 28, 2025
c5d49bf
Update mb-decode-numericentity.xml
mmalferov Aug 28, 2025
e2823c8
Update mb-decode-numericentity.xml
mmalferov Aug 28, 2025
572b665
Update mb-encode-numericentity.xml
mmalferov Aug 28, 2025
6d6871b
Apply suggestions from code review
mmalferov Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions reference/mbstring/functions/mb-decode-numericentity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
&reftitle.errors;
<simpara>
Throws a <exceptionname>ValueError</exceptionname> if
<parameter>map</parameter> is not a list of &integer;s.
<parameter>map</parameter> contains any value that is not an
&integer;, &float;, &boolean;, &null;, or a <link linkend="language.types.numeric-strings">numeric string</link>.
</simpara>
</refsect1>

Expand All @@ -80,9 +81,9 @@
<row>
<entry>8.4.0</entry>
<entry>
<function>mb_decode_numericentity</function> now throws a
The <function>mb_decode_numericentity</function> function now throws a
<exceptionname>ValueError</exceptionname> if <parameter>map</parameter>
is not a list of &integer;s.
contains any value that cannot be implicitly converted to int.
</entry>
</row>
&mbstring.changelog.encoding-nullable;
Expand Down
7 changes: 4 additions & 3 deletions reference/mbstring/functions/mb-encode-numericentity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
&reftitle.errors;
<simpara>
Throws a <exceptionname>ValueError</exceptionname> if
<parameter>map</parameter> is not a list of &integer;s.
<parameter>map</parameter> contains any value that is not an
&integer;, &float;, &boolean;, &null;, or a <link linkend="language.types.numeric-strings">numeric string</link>.
</simpara>
</refsect1>

Expand All @@ -91,9 +92,9 @@
<row>
<entry>8.4.0</entry>
<entry>
<function>mb_encode_numericentity</function> now throws a
The <function>mb_encode_numericentity</function> function now throws a
<exceptionname>ValueError</exceptionname> if <parameter>map</parameter>
is not a list of &integer;s.
contains any value that cannot be implicitly converted to int.
</entry>
</row>
&mbstring.changelog.encoding-nullable;
Expand Down