filter: Refactor filter constants by splitting into separate files - #5886
Merged
Merged
Conversation
lacatoire
approved these changes
Sep 27, 2026
Member
Author
|
@lacatoire It has been mentioned a few times, but please just let members merge their MRs themselves. Unless it either being stale for too long or on request. |
Member
This one was only a split, so i expected i could merge |
This was referenced Sep 29, 2026
KentarouTakeda
added a commit
to php/doc-ja
that referenced
this pull request
Oct 4, 2026
filter の 7 ファイルを原文の変更に追従しました。これで filter モジュールの未訳・要更新はなくなります。 原文では次の変更がありました。 - 定数のページが、入力・一般的なフィルタフラグ・除去フィルタのフラグ・検証フィルタ・除去フィルタ・ユーザー定義のフィルタの 6 ファイルに分割されました（php/doc-en@a109099、php/doc-en#5886）。分割で英文は変わっていないため、新しい 6 ファイルには constants.xml の既訳をそのまま移しています - `FILTER_VALIDATE_DOMAIN` が空白文字や制御文字、NUL バイトまで受け入れることが、例とともに追記されました（php/doc-en@74492d2、php/doc-en#5867） ## 対象ファイル reference/filter/ (7) — constants.xml, constants.callback.xml, constants.flags.generic.xml, constants.flags.sanitization.xml, constants.input.xml, constants.sanitization.xml, constants.validation.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a structural change. The current https://www.php.net/manual/en/filter.constants.php, with all the warnings feels very unorganised. The file itself is also a whopping 1319 lines though that alone is not a reason by itself.
This change splits the filter -> Predefined Constants into sub files.