preg_match: the A modifier works with offset - #5887
Merged
lacatoire merged 1 commit intoSep 27, 2026
Merged
Conversation
lacatoire
approved these changes
Sep 27, 2026
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the wording change from #5652. The text introduced by that PR is:
The problem is that both includes the A modifier. It actually works like this:
By the way, the original PR's description says:
The PR mentions the
\Aanchor. But the docs describe theAmodifier. ChangingAto\Aon the docs side would at least make it not wrong (see the last two examples), but since the text is about avoidingsubstr(), it should still describe theAmodifier.So I think the original text from before that change is the best.