Skip to content

[Sync-En] pdo: revert constant types to int and document the getAttribute() bool change - #1386

Open
lacatoire wants to merge 1 commit into
php:masterfrom
lacatoire:sync-en/1374-pdo-constant-types
Open

lacatoire wants to merge 1 commit into
php:masterfrom
lacatoire:sync-en/1374-pdo-constant-types

Conversation

@lacatoire

Copy link
Copy Markdown
Member

Translation of php/doc-en commit 00b1185: the PDO attribute constants are typed int again, and PDO::getAttribute() documents in its changelog that PHP 8.4.0 returns bool for ATTR_AUTOCOMMIT, ATTR_EMULATE_PREPARES and MYSQL_ATTR_DIRECT_QUERY. The empty xi:fallback elements of pdo-dblib.xml are removed as well, as its EN-Revision now includes that upstream change. EN-Revision updated.

Fixed a few inaccurate sentences in reference/pdo/constants.xml along the way (missing default-mode sentence of ERRMODE_EXCEPTION, catalog/table name prefix wording, allocation/free events, a duplicated PDO:: in a method reference).

Fixes: #1374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sync EN] Revert PDO constant types to int, document getAttribute() bool change

1 participant