Skip to content

Sync #if/ifdef/defined - #14520

Merged
petk merged 1 commit into
php:masterfrom
petk:patch-wundef-3
Jun 11, 2024
Merged

petk merged 1 commit into
php:masterfrom
petk:patch-wundef-3

Conversation

@petk

@petk petk commented Jun 9, 2024 •

Copy link
Copy Markdown
Member

These are either undefined or defined (to value 1):

  • __DragonFly__
  • __FreeBSD__
  • HAS_MCAST_EXT
  • HAVE_GETCWD
  • HAVE_GETWD
  • HAVE_GLIBC_ICONV
  • HAVE_JIT
  • HAVE_LCHOWN
  • HAVE_NL_LANGINFO
  • HAVE_RL_CALLBACK_READ_CHAR
  • HAVE_RL_ON_NEW_LINE
  • HAVE_SQL_EXTENDED_FETCH
  • HAVE_UTIME

Follow up of GH-5526 (-Wundef)

These are either undefined or defined (to value 1):
- __DragonFly__
- __FreeBSD__
- HAS_MCAST_EXT
- HAVE_GETCWD
- HAVE_GETWD
- HAVE_GLIBC_ICONV
- HAVE_JIT
- HAVE_LCHOWN
- HAVE_NL_LANGINFO
- HAVE_RL_CALLBACK_READ_CHAR
- HAVE_RL_ON_NEW_LINE
- HAVE_SQL_EXTENDED_FETCH
- HAVE_UTIME

Follow up of phpGH-5526 (-Wundef)

@TimWolla TimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack for ext/random

@devnexen devnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for sockets

@petk

petk commented Jun 11, 2024

Copy link
Copy Markdown
Member Author

Merge coming up here. These aren't problematic changes overall.

@petk
petk merged commit 5d3fab9 into php:master Jun 11, 2024
@petk
petk deleted the patch-wundef-3 branch June 11, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants