reflection: Fix the return value of ReflectionFunction::{getNamespaceName,inNamespace}() for closures - #16129
Merged
Merged
Conversation
…Name,inNamespace}() for closures Fixes phpGH-16122
mvorisek
reviewed
Sep 30, 2024
iluuu1994
approved these changes
Sep 30, 2024
iluuu1994
left a comment
Member
There was a problem hiding this comment.
It's unfortunate we have an unnoticed BC break after RC, but I agree with your assessment that "namespacename + shortname = name" should be true.
cmb69
reviewed
Sep 30, 2024
cmb69
left a comment
Member
There was a problem hiding this comment.
It's unfortunate we have an unnoticed BC break after RC
Well, the current output is just broken, so needs to be fixed anyway.
TimWolla
added a commit
that referenced
this pull request
Sep 30, 2024
* PHP-8.4:
reflection: Fix the return value of ReflectionFunction::{getNamespaceName,inNamespace}() for closures (#16129)
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
…Name,inNamespace}() for closures (php#16129) * reflection: Fix the return value of ReflectionFunction::{getNamespaceName,inNamespace}() for closures Fixes phpGH-16122 * reflection: Clean up implementation of `ReflectionFunctionAbstract::inNamespace()` * reflection: Clean up implementation of `ReflectionFunctionAbstract::getNamespaceName()`
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the (reasonable) assumption that namespacename + shortname = name, the only option is to return an empty namespace and return false when asking if the closure is inside of a namespace.
Fixes GH-16122