Skip to content

Fix GH-16149: Null pointer dereference in DOMElement->getAttributeNames() - #16155

Closed
ndossche wants to merge 1 commit into
php:PHP-8.3from
ndossche:fix-16149
Closed

Fix GH-16149: Null pointer dereference in DOMElement->getAttributeNames()#16155
ndossche wants to merge 1 commit into
php:PHP-8.3from
ndossche:fix-16149

Conversation

@ndossche

@ndossche ndossche commented Oct 1, 2024

Copy link
Copy Markdown
Member

A namespace without a prefix is by definition always the "xmlns" namespace.

@ndossche
Fix phpGH-16149: Null pointer dereference in DOMElement->getAttribute…
859aafc 
…Names()

A namespace without a prefix is by definition always the "xmlns"
namespace.
@ndossche ndossche linked an issue Oct 1, 2024 that may be closed by this pull request
Null pointer dereference in DOMElement -> getAttributeNames() #16149
Closed
Girgias
Girgias approved these changes Oct 1, 2024
View reviewed changes

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@Girgias

Girgias commented Oct 1, 2024

Copy link
Copy Markdown
Member

Normal for the 8.3 target?

@ndossche

ndossche commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

Normal for the 8.3 target?

Yes this is the intended target

cmb69
cmb69 approved these changes Oct 1, 2024
View reviewed changes

@cmb69 cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ndossche ndossche closed this in 63e1ebe Oct 1, 2024
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
@ndossche @jorgsowa
Fix phpGH-16149: Null pointer dereference in DOMElement->getAttribute…
d070bfe 
…Names()

A namespace without a prefix is by definition always the "xmlns"
namespace.

Closes phpGH-16155.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes
@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: dom

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Null pointer dereference in DOMElement -> getAttributeNames()

3 participants

@ndossche @Girgias @cmb69