Fix GH-15893: Pdo\Pgsql backport fixes from GH-16124 - #16158
Conversation
|
Hm you updated arginfo but I don't see stub changes? |
|
that was a mistake.. |
4fe0b0d to
9051f5f
Compare
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (iter->funcs->rewind) { |
There was a problem hiding this comment.
I think rewind can throw too, but the exception isn't checked in this case.
There was a problem hiding this comment.
Right, I forgot about that detail.
Maybe would be nice to have some FOREACH_ITERABLE macros 🤔
Girgias
left a comment
There was a problem hiding this comment.
I would prefer to change ZPP to fast ZPP so that you can use Z_PARAM_ITERABLE here. As the type error message is not consistent with other TypeError messages atm.
2bc53b4 to
fd7cb52
Compare
Girgias
left a comment
There was a problem hiding this comment.
Other than the comment from Niels, LGTM
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (iter->funcs->rewind) { |
There was a problem hiding this comment.
Right, I forgot about that detail.
Maybe would be nice to have some FOREACH_ITERABLE macros 🤔
There was a problem hiding this comment.
In the old zpp this argument was not nullable, it was the last one. The fact this is not caught in CI also means that this case is not tested...
a275127 to
d2a9918
Compare
ndossche
left a comment
There was a problem hiding this comment.
LGTM
Windows failure is unrelated (I already pinged Arnaud)
No description provided.