Conversation
jorgsowa
reviewed
Aug 16, 2026
Comment on lines
+355
to
+362
| static int sapi_cli_activate(void) /* {{{ */ | ||
| { | ||
| #if defined(PHP_WIN32) && defined(ZTS) | ||
| ZEND_TSRMLS_CACHE_UPDATE(); | ||
| #endif | ||
| return SUCCESS; | ||
| } | ||
| /* }}} */ |
Contributor
There was a problem hiding this comment.
Suggested change
| static int sapi_cli_activate(void) /* {{{ */ | |
| { | |
| #if defined(PHP_WIN32) && defined(ZTS) | |
| ZEND_TSRMLS_CACHE_UPDATE(); | |
| #endif | |
| return SUCCESS; | |
| } | |
| /* }}} */ | |
| static int sapi_cli_activate(void) | |
| { | |
| #if defined(PHP_WIN32) && defined(ZTS) | |
| ZEND_TSRMLS_CACHE_UPDATE(); | |
| #endif | |
| return SUCCESS; | |
| } |
Those brackets are not necessary anymore
Member
|
@henderkes as you've been looking at ZTS recently care to have a look? |
henderkes
approved these changes
Sep 6, 2026
henderkes
left a comment
Contributor
There was a problem hiding this comment.
Old brace thingies aside, this is correct. I assume swoole runs into it in its threaded worker handler mode.
Member
I guess this needs bacporting to 8.4 too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.