Skip to content

AttributeVersionRequirementHelper: add defaults to bool parameters#312

Merged
staabm merged 1 commit into
phpstan:2.0.xfrom
staabm:defaults
Jul 4, 2026
Merged

AttributeVersionRequirementHelper: add defaults to bool parameters#312
staabm merged 1 commit into
phpstan:2.0.xfrom
staabm:defaults

Conversation

@staabm

@staabm staabm commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

should fix phpstan-src CI error in e2e/result-cache-restore-without-reflection:

In Resolver.php line 677:
                                                                               
  [Nette\DI\ServiceCreationException]                                          
  Service of type PHPStan\Rules\PHPUnit\AttributeRequiresPhpVersionRule: Para  
  meter $deprecationRulesInstalled in AttributeRequiresPhpVersionRule::__cons  
  truct() has no class type or default value, so its value must be specified.  
                                                                               

Exception trace:
  at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/Resolver.php:677
 Nette\DI\Resolver::autowireArgument() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/Resolver.php:572
 Nette\DI\Resolver::autowireArguments() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/Resolver.php:229
 Nette\DI\Resolver->completeStatement() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/Definitions/ServiceDefinition.php:178
 Nette\DI\Definitions\ServiceDefinition->complete() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/Resolver.php:173
 Nette\DI\Resolver->completeDefinition() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/ContainerBuilder.php:338
 Nette\DI\ContainerBuilder->complete() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/Compiler.php:275
 Nette\DI\Compiler->processBeforeCompile() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/Compiler.php:212
 Nette\DI\Compiler->compile() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/ContainerLoader.php:119
 Nette\DI\ContainerLoader->generate() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/ContainerLoader.php:80
 Nette\DI\ContainerLoader->loadFile() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/di/src/DI/ContainerLoader.php:44
 Nette\DI\ContainerLoader->load() at /home/runner/work/phpstan-src/phpstan-src/src/DependencyInjection/Configurator.php:111
 PHPStan\DependencyInjection\Configurator->loadContainer() at /home/runner/work/phpstan-src/phpstan-src/vendor/nette/bootstrap/src/Bootstrap/Configurator.php:258

@staabm staabm marked this pull request as ready for review July 4, 2026 07:31
@staabm staabm merged commit 1e573d3 into phpstan:2.0.x Jul 4, 2026
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant