update phpstan/phpstan-phpunit#5972
Draft
staabm wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
the errors we see here are related to phpstan-src analyzing the codebase with a fixed PHP_VERSION_ID and the phpversion is compared since phpstan/phpstan-phpunit#269 against I am not yet sure how/where to fix it properly |
Member
|
Why is this rule reporting a problem in this situation when an ordinary Also I'd argue the error message of the rule should be improved. "Version requirement will always evaluate to false." doesn't tell the left and right side of the comparison (and also what the comparison is). All of that would improve the error message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.