Skip to content

πŸ”§ invitation ops: copy-link/resend, revoke status-guard, duplicate-pending guardΒ #3834

Description

@PierreBrisorgueil

Cross-PR review 2026-06-11:

  • No copy-link/resend: create() emails best-effort (silent skip if mailer unconfigured, .catch logs only) and the list strips the token β†’ a failed invite email is irrecoverable from the UI (revoke + re-create = same risk). The CREATE response does include the token: add a one-time copy-link affordance in both views, and/or a resend endpoint.
  • revoke() has no status guard ({_id} filter only): can revoke an ACCEPTED invite via API (corrupts future referral counts β€” flips status while keeping acceptedAt/acceptedUserId) and revoke mid-claim (benign race β€” in-flight signup still succeeds, attribution skipped; document). Fix: filter {_id, status:'pending'} β†’ 409 otherwise.
  • No duplicate-pending guard: the same email can hold N pending invites (token path burns the clicked one, OAuth burns the newest, siblings zombie as Pending; with different inviters, referredBy = whichever won). Fix: 409 or revoke-supersede in create().
    Refs: πŸ”’ Invitation edge-case hardeningΒ #3811, epic 🎯 Decouple invitations from organizations (referral-ready platform invitations)Β #3808.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions