Skip to content

🔧 Mail call sites: drop hand-built appName/appContact, brand the subjects #4131

Description

@PierreBrisorgueil

What

  • Remove appName and appContact from the params at the 14 sendMail sites, since the mailer now injects them.
  • Switch the 8 subjects that embed the app title to getBrand().name:
    • billing.email.js: 5 subjects
    • billing.referral.service.js:174
    • invitations.service.js:27
    • organizations.service.js:159
  • Subjects built from org.name, and the 4 fixed English subjects, are unchanged.

Acceptance criteria

  • No call site reads config.app.title or config.app.contact to build a mail.
  • With no brand config, rendered bodies and subjects are unchanged, and the baseline snapshot still passes.
  • With mailer.brand.name set, the body and subject of each mail that names the app use the same name.

Tests

  • Update billing.init.email-alerts, organizations.membership.addMember.email and organizations.service.welcomeEmail.
  • Add a subject assertion with a brand-name override.

Depends on: brand.
Refs: auth.password.controller, auth.signup.service, users.service, invitations.service, organizations(.membership).service, billing.email, billing.referral.service

Needs: #4128

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions