Raft cache persist improve - #5
Merged
Merged
Conversation
solotzg
reviewed
Feb 26, 2019
|
|
||
| template <bool is_set, typename T, template <typename E = T, typename...> class Container, class Write, class Read> | ||
| struct PersistedContainerSetOrVector | ||
| template <bool is_map, bool is_set, class Trait> |
Contributor
There was a problem hiding this comment.
maybe we can make abstraction in the concept of Iterator later if have time.
Contributor
Author
There was a problem hiding this comment.
The problem is map use K and V, while others use T only. I can unify map by std::pair<K, V>, but not user friendly.
windtalker
added a commit
to windtalker/tiflash
that referenced
this pull request
Mar 6, 2023
Signed-off-by: xufei <xufei@pingcap.com>
12 tasks
JinheLin
pushed a commit
to JinheLin/tiflash-1
that referenced
this pull request
Apr 2, 2024
Decrease indents of readColumn
premal
added a commit
to 6si/tiflash
that referenced
this pull request
Jun 25, 2026
…esponseWriter Bug pingcap#5: DMFileReader::readWithFilter calls insertSelectiveFrom/insertRangeFrom on ColumnDictionary columns; ColumnString::insertSelectiveRangeFrom does an unchecked static_cast<ColumnString> which returns garbage sizes and causes 128 TiB allocation. Bug pingcap#6: StreamingDAGResponseWriter (root MPP task writer) did not call materializeBlocks() before encoding, leaving ColumnDictionary columns for memory accounting (block.allocatedBytes()) which could interact with memory tracking code paths and cause 8 EiB allocation. Both fixes add convertToFullColumnIfDictionary() in the affected paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://internal.pingcap.net/jira/browse/FLASH-115