FLASH-143: Enable CI tests - #7
Merged
Merged
Conversation
Contributor
|
/run-integration-tests |
Contributor
Author
|
/run-integration-tests |
1 similar comment
Contributor
Author
|
/run-integration-tests |
windtalker
added a commit
to windtalker/tiflash
that referenced
this pull request
Mar 6, 2023
* save work Signed-off-by: xufei <xufei@pingcap.com> * Update dbms/src/Interpreters/Join.cpp Co-authored-by: Meng Xin <tregoldmeng@gmail.com> --------- Signed-off-by: xufei <xufei@pingcap.com> Co-authored-by: Meng Xin <tregoldmeng@gmail.com>
12 tasks
zanmato1984
added a commit
that referenced
this pull request
Apr 7, 2026
Role: Coder-R139: add donor host-v2 inner-hash-join parity entrypoint
devin-ai-integration Bot
added a commit
to 6si/tiflash
that referenced
this pull request
Jun 25, 2026
… handle ColumnDictionary source Bug pingcap#7 (G2 crash): ColumnString::insertSelectiveRangeFrom did an unchecked static_cast<const ColumnString&> on the source column. When the source is ColumnDictionary (from late materialization in DMFileReader), this reads garbage offsets and computes ~8 EiB allocation -> mmap failure. Fix: Add isDictionaryEncoded() check at the start of insertFrom, insertManyFrom, and insertSelectiveRangeFrom. If source is ColumnDictionary, materialize via convertToFullColumnIfDictionary() before proceeding. This is the same pattern already used in insertRangeFrom. The fix is defensive — it catches ALL call sites that pass ColumnDictionary to ColumnString insert methods, regardless of whether the caller remembered to materialize first. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
This PR: