Skip to content

Honor configured protocol for automatic repository clones - #4205

Closed
MisterJimson wants to merge 3 commits into
pingdotgg:mainfrom
MisterJimson:jason/codex/honor-github-clone-protocol
Closed

Honor configured protocol for automatic repository clones#4205
MisterJimson wants to merge 3 commits into
pingdotgg:mainfrom
MisterJimson:jason/codex/honor-github-clone-protocol

Conversation

@MisterJimson

@MisterJimson MisterJimson commented Jul 20, 2026

Copy link
Copy Markdown

Summary

  • keep the default Create & Clone flow protocol-aware instead of hardcoding a concrete clone URL
  • honor GitHub CLI's per-host git_protocol setting for automatic clones
  • preserve explicit HTTPS and SSH behavior, using HTTPS as the safe fallback when a provider cannot report a preference
  • add focused web, GitHub CLI, and repository-service regression coverage

Why

The Create & Clone UI passed repository.sshUrl directly to the clone operation, bypassing the existing auto protocol path. Remote servers authenticated with gh over HTTPS but without a GitHub SSH key therefore failed to clone private repositories even though HTTPS access was valid.

The UI now submits the provider and repository identity with protocol: "auto". For GitHub, repository lookup reads gh config get git_protocol --host <host> and carries that preference into clone selection. A reported SSH preference still uses SSH, a reported HTTPS preference uses HTTPS, and an unavailable preference falls back to HTTPS instead of recreating the original authentication failure.

Explicit URL clones remain unchanged.

Fixes #4203.

Testing

  • vp test run apps/server/src/sourceControl/GitHubCli.test.ts apps/server/src/sourceControl/SourceControlRepositoryService.test.ts apps/web/src/components/CommandPalette.logic.test.ts (22 tests passed)
  • pnpm --filter @t3tools/contracts typecheck
  • pnpm --filter t3 typecheck
  • pnpm --filter @t3tools/web typecheck

An isolated UI smoke-test startup was attempted, but this nightly checkout's Vite+ dev server is independently blocked by Tsconfig not found @tsconfig/node24/tsconfig.json.


Note

Medium Risk
Changes clone URL selection for provider-based clones, which can affect how private repos authenticate (HTTPS vs SSH). Explicit protocol and URL clones stay the same.

Overview
Create & Clone no longer hardcodes SSH. Looked-up repos now clone with protocol: "auto" so GitHub’s per-host gh config git_protocol can choose HTTPS vs SSH.

GitHub lookup reads gh config get git_protocol --host <host> and attaches optional preferredProtocol. Auto clones use SSH only when that preference is ssh; otherwise they use HTTPS (including when config is missing). Explicit HTTPS/SSH and raw clone URLs are unchanged.

Reviewed by Cursor Bugbot for commit 6a164a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Honor configured git_protocol for automatic repository clones

  • GitHubCli.Service.getRepositoryCloneUrls now runs an extra gh config get git_protocol --host <host> lookup and attaches preferredProtocol ("ssh" | "https") to the returned clone URLs. Errors during this step are tolerated.
  • selectRemoteUrl changes automatic protocol selection: SSH is only chosen when preferredProtocol is explicitly "ssh"; otherwise HTTPS is used. Explicit "ssh"/"https" branches are unchanged.
  • The Command Palette UI defaults looked-up repositories to the HTTPS URL and routes cloning through the new getCloneSourceInput helper with protocol: "auto".
  • Contracts in sourceControl.ts add an optional preferredProtocol field to SourceControlRepositoryCloneUrls and SourceControlRepositoryInfo.
  • Behavioral Change: automatic cloning now prefers HTTPS instead of SSH unless the provider's gh config explicitly sets git_protocol to SSH for the host. Review selectRemoteUrl in SourceControlRepositoryService.ts.

Macroscope summarized 6a164a7.

@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Jul 20, 2026
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01e5a870-48e6-4d15-9556-73216118b7b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 changed lines (additions + deletions). label Jul 20, 2026
@MisterJimson
MisterJimson marked this pull request as ready for review July 20, 2026 20:37
@macroscopeapp

macroscopeapp Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new runtime behavior by querying gh config for protocol preferences and changing how clone URLs are selected (previously defaulted to SSH, now uses configured preference with HTTPS fallback). New feature functionality affecting clone operations warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@MisterJimson MisterJimson changed the title Use HTTPS for automatic repository clones Honor configured protocol for automatic repository clones Jul 21, 2026
@MisterJimson
MisterJimson marked this pull request as draft July 21, 2026 14:03
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Jul 21, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2dc2225. Configure here.

Comment thread apps/server/src/sourceControl/SourceControlRepositoryService.ts Outdated
@maria-rcks
maria-rcks marked this pull request as ready for review August 21, 2026 06:38
@t3dotgg

t3dotgg commented Aug 23, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Closing this PR after an automated pass over open pull requests. Contradicts the repository clone protocol policy established in #7760.

@t3dotgg t3dotgg closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Auto clone selects SSH despite gh configured for HTTPS

2 participants