fix(web): binary files get a real empty state instead of a raw read error - #6038
fix(web): binary files get a real empty state instead of a raw read error#6038tsouth89 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 2597729 This is a straightforward UI improvement that replaces a raw error message with a friendly empty state for binary files. The changes are self-contained, use existing UI primitives, and include unit tests with no runtime behavior changes beyond better error presentation. You can customize Macroscope's approvability policy. Learn more. |
…rror Clicking a chat file link for a build artifact — an installer, an archive, a recording — opened the file panel onto a dead end. The panel printed the read error verbatim in red, which named the internal failure and repeated the absolute workspace root, and offered nothing to do next. The panel could not tell a binary file apart from any other read failure. The server raises a typed WorkspaceBinaryFileError, but ws.ts folds it into ProjectReadFileError, so only the structured `failure` discriminator survives to the client and the query state was dropping it. Surface that field, then render a proper empty state for `binary_file` that names the file and hands back its path. Every other read failure keeps the existing message. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2597729 to
e167768
Compare
Closes part of #4973.
What changed
Clicking a chat file link for a build artifact — an installer, an archive, a recording — opened the file panel onto a dead end. The panel printed the read error verbatim in red: it named the internal failure, repeated the absolute workspace root, and offered nothing to do next.
The panel had no way to tell a binary file apart from any other read failure. The server raises a typed
WorkspaceBinaryFileError, butws.tsfolds it intoProjectReadFileError, so the only thing that survives to the client is the structuredfailurediscriminator — and the query state was dropping it on the floor. This surfaces that field, then renders a proper empty state forbinary_filethat names the file and hands back its path. Every other read failure keeps the message it shows today.Why
#4973 asks for artifacts T3 Code cannot open to stop being useless links. #5366 covers the context-menu half of that with "Open in folder". This is the other half: the state you actually land on when you click. The two compose — once #5366 lands, "Open in folder" is the natural second action to drop into this empty state.
Keying on
failurerather than the error message also means the panel is no longer one prose edit away from silently falling back to the raw string.UI changes
Captured in a real client against a 9.6 MB
.exein the workspace, dark theme, file explorer collapsed so the preview area is legible.Verification
vp test run src/components/files/FilePreviewPanel.test.ts --project unit— 9 passedpnpm --filter @t3tools/web typecheckvp linton the four changed filesCopy pathcopies the absolute path. The before/after images above are from that pass.Checklist
Written by Claude Opus 5 in Claude Code.
Note
Low Risk
UI-only branching on an existing server failure code; non-binary errors unchanged and behavior is covered by new unit tests.
Overview
When a workspace file read fails because the content is not UTF-8 text (
binary_file), the file preview panel now shows a dedicated empty state instead of the raw server error string.Project file query hooks expose a structured
errorFailurealongside the error message so the UI can branch on failure type without parsing prose.FilePreviewPaneluses that to renderBinaryFilePreview: a short description naming the file (basename only) and an optional Copy path action when an absolute path is available. Other read failures still use the existing destructive error message.Helpers
isBinaryFilePreviewErrorandbinaryFilePreviewDescriptioninfilePreviewMode.tscentralize detection and copy; unit tests cover them.Reviewed by Cursor Bugbot for commit e167768. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Replace raw read error with empty state UI for binary file previews
isBinaryFilePreviewErrorandbinaryFilePreviewDescriptionhelpers in filePreviewMode.ts to detect and describe binary file failures using a structured'binary_file'failure code.BinaryFilePreviewcomponent in FilePreviewPanel.tsx that shows an empty state with the filename and a 'Copy path' button (with clipboard feedback) instead of a raw error message.errorFailurefield alongsideerror, enabling the panel to branch on failure type.Macroscope summarized e167768.