Skip to content

fix(web): binary files get a real empty state instead of a raw read error - #6038

Open
tsouth89 wants to merge 1 commit into
pingdotgg:mainfrom
tsouth89:fix/file-preview-binary-empty-state
Open

fix(web): binary files get a real empty state instead of a raw read error#6038
tsouth89 wants to merge 1 commit into
pingdotgg:mainfrom
tsouth89:fix/file-preview-binary-empty-state

Conversation

@tsouth89

@tsouth89 tsouth89 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Closes part of #4973.

What changed

Clicking a chat file link for a build artifact — an installer, an archive, a recording — opened the file panel onto a dead end. The panel printed the read error verbatim in red: it named the internal failure, repeated the absolute workspace root, and offered nothing to do next.

The panel had no way to tell a binary file apart from any other read failure. The server raises a typed WorkspaceBinaryFileError, but ws.ts folds it into ProjectReadFileError, so the only thing that survives to the client is the structured failure discriminator — and the query state was dropping it on the floor. This surfaces that field, then renders a proper empty state for binary_file that names the file and hands back its path. Every other read failure keeps the message it shows today.

Why

#4973 asks for artifacts T3 Code cannot open to stop being useless links. #5366 covers the context-menu half of that with "Open in folder". This is the other half: the state you actually land on when you click. The two compose — once #5366 lands, "Open in folder" is the natural second action to drop into this empty state.

Keying on failure rather than the error message also means the panel is no longer one prose edit away from silently falling back to the raw string.

UI changes

Before After

Captured in a real client against a 9.6 MB .exe in the workspace, dark theme, file explorer collapsed so the preview area is legible.

Verification

  • vp test run src/components/files/FilePreviewPanel.test.ts --project unit — 9 passed
  • pnpm --filter @t3tools/web typecheck
  • vp lint on the four changed files
  • One integrated pass in a real client: opened a binary artifact in the file panel and confirmed the empty state renders and Copy path copies the absolute path. The before/after images above are from that pass.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for the UI change
  • I included a video for animation/interaction changes — not applicable, no motion

Written by Claude Opus 5 in Claude Code.


Note

Low Risk
UI-only branching on an existing server failure code; non-binary errors unchanged and behavior is covered by new unit tests.

Overview
When a workspace file read fails because the content is not UTF-8 text (binary_file), the file preview panel now shows a dedicated empty state instead of the raw server error string.

Project file query hooks expose a structured errorFailure alongside the error message so the UI can branch on failure type without parsing prose. FilePreviewPanel uses that to render BinaryFilePreview: a short description naming the file (basename only) and an optional Copy path action when an absolute path is available. Other read failures still use the existing destructive error message.

Helpers isBinaryFilePreviewError and binaryFilePreviewDescription in filePreviewMode.ts centralize detection and copy; unit tests cover them.

Reviewed by Cursor Bugbot for commit e167768. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace raw read error with empty state UI for binary file previews

  • Adds isBinaryFilePreviewError and binaryFilePreviewDescription helpers in filePreviewMode.ts to detect and describe binary file failures using a structured 'binary_file' failure code.
  • Introduces a BinaryFilePreview component in FilePreviewPanel.tsx that shows an empty state with the filename and a 'Copy path' button (with clipboard feedback) instead of a raw error message.
  • Extends query state in projectFilesQueryState.ts to surface a structured errorFailure field alongside error, enabling the panel to branch on failure type.

Macroscope summarized e167768.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 20cea99c-76a3-47ba-bea5-b96e9e2b370e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 2597729

This is a straightforward UI improvement that replaces a raw error message with a friendly empty state for binary files. The changes are self-contained, use existing UI primitives, and include unit tests with no runtime behavior changes beyond better error presentation.

You can customize Macroscope's approvability policy. Learn more.

…rror

Clicking a chat file link for a build artifact — an installer, an archive,
a recording — opened the file panel onto a dead end. The panel printed the
read error verbatim in red, which named the internal failure and repeated
the absolute workspace root, and offered nothing to do next.

The panel could not tell a binary file apart from any other read failure.
The server raises a typed WorkspaceBinaryFileError, but ws.ts folds it into
ProjectReadFileError, so only the structured `failure` discriminator
survives to the client and the query state was dropping it. Surface that
field, then render a proper empty state for `binary_file` that names the
file and hands back its path. Every other read failure keeps the existing
message.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@tsouth89
tsouth89 force-pushed the fix/file-preview-binary-empty-state branch from 2597729 to e167768 Compare August 16, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant