Skip to content

fix(clients): reconnect after credentials fail during remote server updates - #7953

Merged
t3dotgg merged 1 commit into
mainfrom
t3code/fix-mac-remote-update-reconnecting
Aug 23, 2026
Merged

fix(clients): reconnect after credentials fail during remote server updates#7953
t3dotgg merged 1 commit into
mainfrom
t3code/fix-mac-remote-update-reconnecting

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Aug 23, 2026

Copy link
Copy Markdown
Member

Remote server updates on macOS can briefly reject an environment credential after the new server starts. The connection supervisor then blocks, and the update recovery loop never retries it.

Retry authentication failures once per second while an update is resuming. Permission and configuration failures remain blocked.

Tests: 55 focused client runtime, authorization, and connection supervisor tests pass.

Built with GPT-5.6 Sol using Codex.


Note

Medium Risk
Touches reconnect retry during server updates, including authentication-blocked states. The extra retries are limited to the update-resume window and exclude permission/configuration failures.

Overview
During a remote server update restart, reconnect nudges now also fire when the supervisor is blocked on authentication, not only while it is in backoff.

A newly restarted server can reject the first environment credential and leave the client stuck. nudgeReconnectDuringUpdateRestart now retries those auth blocks on the same ~1s cadence used for backoff. Permission and configuration failures stay blocked. A unit test covers that only authentication blocks are retried.

Reviewed by Cursor Bugbot for commit 208a63d. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix nudgeReconnectDuringUpdateRestart to retry on authentication blocks

  • Expands nudgeReconnectDuringUpdateRestart in server.ts to schedule paced retries for states blocked by authentication errors during remote server update restarts.
  • Broadens the filter from only phase === "backoff" to also include phase === "blocked" when lastFailure?.reason === "authentication".
  • Behavioral Change: permission and configuration failures are explicitly excluded from retries and will no longer trigger reconnect nudges.

Macroscope summarized 208a63d.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 082bf040-dfa0-498a-b737-f02b7d31c00b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.4 KiB 13.4 KiB −5 B (−0.0%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 6.9 KiB 0 B (0.0%) 7.3 KiB
Codex Live turn WebSocket wire 6.6 KiB 6.5 KiB −5 B (−0.1%) 7.8 KiB
Codex Live turn WebSocket decoded 55.0 KiB 55.0 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 13.4 KiB 13.4 KiB −1 B (−0.0%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 6.9 KiB −12 B (−0.2%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.6 KiB +11 B (+0.2%) 7.8 KiB
Claude Live turn WebSocket decoded 55.8 KiB 55.8 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: 30be311 · PR result: 208a63d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@t3dotgg
t3dotgg merged commit afa8309 into main Aug 23, 2026
23 checks passed
@t3dotgg
t3dotgg deleted the t3code/fix-mac-remote-update-reconnecting branch August 23, 2026 06:25
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 23, 2026
## What's Changed
* fix(clients): reconnect after credentials fail during remote server updates by @t3dotgg in pingdotgg/t3code#7953
* feat(codex): submit thread feedback to OpenAI by @t3dotgg in pingdotgg/t3code#7949
* fix(server): stop kills lingering Claude work by @t3dotgg in pingdotgg/t3code#5891
* fix(ci): let Macroscope approve pull requests again by @t3dotgg in pingdotgg/t3code#7970


**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260823.1166...v0.0.34-nightly.20260823.1167

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260823.1167
pandec added a commit to pandec/t3code that referenced this pull request Aug 23, 2026
Fast-forwards main from 30be311 to f70eeee (6 commits, 47 files) and
merges it into dev. Small in commits, heavy in fork contact: 19 files
carried fork delta, giving 19 conflicts across 42 hunks.

Upstream lands Codex /feedback upload to OpenAI (pingdotgg#7949), a Claude Stop
rewrite that kills lingering work instead of only interrupting the turn
(pingdotgg#5891), settled pinned threads moving into the settled shelf (pingdotgg#7969),
and a credentials-failure reconnect during remote server updates (pingdotgg#7953).

Notable resolutions. Classification on both clients is now snoozed,
settled, pinned, Older, with the fork's Older grouping still last so it
never claims a lifecycle-owned row. ProviderService.test.ts and the mobile
send callback both had misaligned hunks and were reconstructed from each
side rather than resolved marker by marker; taking upstream there would
have dropped deliveryIntent and the bounded message window, both of which
compile. uploadFeedback takes the fork's per-thread lock. Claude's
session.exited keeps its sessionGenerationId and the usage-fiber
cancellation survives upstream's close-first teardown.

Two fixes a clean merge would not have caught: the fork's running composer
left Queue and Steer enabled while submitComposer refused them, and card
rows keep the passive pin marker because upstream's now-focusable
indicator hid itself inside the fork's focus-hide wrapper.

vp check, typecheck, and focused tests pass. Full suite green except the
documented PortScanner pair caused by a foreign dev server on [::1]:3000.

Reviewed and merged by Claude Opus 5 in Claude Code, with gpt-5.6-sol
subagents for the behavioral reviews and post-merge audits.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 23, 2026
cloudbridgeuy pushed a commit to cloudbridgeuy/t3code that referenced this pull request Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant