fix(server): keep previously used providers working after upgrades

[t3dotgg]

Provider defaults changed, but stable releases omitted default enabled values from saved settings. Existing Cursor, Grok, and OpenCode threads could stop working after an upgrade.

Read persisted thread sessions and provider runtime sessions before loading provider settings. Restore only providers and provider instances that have real usage history, keep unused providers disabled, preserve explicit enables and disables across restarts, and restore used providers even when settings are invalid.

Verified with 87 focused settings, provider contract, provider registry, and startup tests, two integrated server startup tests, and server and contracts type checking.

Made by GPT-5.6 Sol through the Codex harness.

Note

Restore previously used optional providers (cursor, grok, opencode) on settings load

• loadSettingsFromDisk in serverSettings.ts now queries provider usage history from projection_thread_sessions and provider_session_runtime, then enables optional providers and their instances that were previously used but lack explicit enabled flags.
• Adds PersistedOptionalProviderSettings schema for lenient decoding of just the optional provider enabled flags, so valid flags survive even when other settings fields are invalid JSON.
• writeSettingsAtomically now uses PERSISTED_SERVER_SETTINGS_DEFAULTS (with optional provider enabled set to undefined) so explicit enabled:false entries are retained in the persisted sparse JSON.
• ServerSettingsLayerLive in server.ts is now wired with SqlitePersistenceLayerLive to support the history queries.
• Risk: getSettings now fails with ServerSettingsError(operation="read-provider-history") if the provider history SQL query fails; callers handling ServerSettingsError should account for this new operation literal added in settings.ts.

^{Macroscope summarized 7252980.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d9ecff7c-b4d6-414a-958d-d53c61da092c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−16 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	−3 B (−0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−13 B (−0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	−44 B (−0.1%)	66.4 KiB	✅
Codex	Live turn messages	11	10	−1 (−9.1%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−84 B (−0.6%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−3 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−81 B (−1.2%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	−88 B (−0.2%)	66.4 KiB	✅
Claude	Live turn messages	11	9	−2 (−18.2%)	21	✅

Baseline: 1a4a759 · PR result: 7252980 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — Provider activation now depends on persisted database history, affecting startup hydration, provider probing, fallback selection, and settings-read failure behavior. The SQLite dependency and changed enablement semantics make this a material runtime change rather than a narrowly isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 7ec7746

[macroscopeapp]

One finding on error modeling for the new provider-history query. Import namespaces, Context.Service/make/layer shape, and dependency acquisition (yield* SqlClient.SqlClient with SqlClient surfaced in layer's requirements and provided in server.ts) all look consistent with the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f492427. Configure here.}