fix: bind docs server and preserve runtime port defaults - #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Docusaurus defaults to
localhostwhen--hostis omitted, so Docker port publishing cannot reach the server. A subsequent directmainchange added configurableHOSTandPORTbuild args beforeFROM, but Docker does not expose those values inside the production stage unless they are redeclared. That produced commands such asdocusaurus serve --host --port 8000and the container exited.Fix
ENV,PORT, andHOSTbuild arguments inside the production stageHOST=0.0.0.0andPORT=8000PORT=3000Verification
Reproduced before the fix:
http://localhost:8000/; Docker-published traffic failedmainimage exited withdocusaurus serve --host --port 8000when onlyPORTwas providedVerified after the fix:
http://0.0.0.0:8000/and returns HTTP 200PORT=3000serveshttp://0.0.0.0:3000/and returns HTTP 200