fix(search): match a package whose family the metadata has dropped - #201
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe change adds repository-wide package-name counting. List and search operations pass these counts to installation matching, which now handles exact families and constrained family-independent matches. ChangesPackage installation matching
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The current change has no identified actionable merge-blocking risk and is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant ListSearch
participant MetadataRepository
participant is_installed
ListSearch->>MetadataRepository: Query package-name offering counts
MetadataRepository-->>ListSearch: Return name and family counts
ListSearch->>is_installed: Pass offering counts and package metadata
is_installed-->>ListSearch: Return installation status
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying soar-docs with
|
| Latest commit: |
0e3afad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b2ed870c.soar-docs.pages.dev |
| Branch Preview URL: | https://fix-search-family.soar-docs.pages.dev |
A name the repository offers once and holds once means one package however its family was recorded, which is what a family dropped by later metadata leaves nothing else to match on. A name standing for more than one still has to match its family exactly.
6685557 to
0e3afad
Compare
…tadata has dropped (pkgforge#201) ⌚
Summary by CodeRabbit