Track the consumer's opentelemetry major in sqlcommenter - #3
Open
graemer957 wants to merge 1 commit into
Open
Conversation
OpenTelemetry keeps its propagator and tracer-provider registries in version-specific statics, so a second copy of `opentelemetry` in the tree doesn't share that state — `sqlcommenter` silently stops injecting SQL comments while `db.query` spans still export, with no error or warning. Pinning the fork's `opentelemetry`/`tracing-opentelemetry` to the line the consumer uses keeps exactly one copy in their dependency graph.
graemer957
marked this pull request as ready for review
June 26, 2026 12:43
graemer957
marked this pull request as draft
July 2, 2026 13:54
graemer957
marked this pull request as ready for review
July 2, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move
sqlcommenter'sopentelemetryto the 0.32 line (opentelemetry0.32,tracing-opentelemetry0.33).How
The fork's OTel version has to match whatever the consuming app resolves, because OTel's global registries are per-version statics — a mismatched copy silently disables
sqlcommenter(SQL comments stop,db.queryspans keep exporting, nothing errors). This tracks a consumer moving onto the 0.32 line.Testing
Compiled the consumer (platformed) against this branch on the 0.32 OTel line — green. The
sqlcommenterAPI surface used (Injector,get_text_map_propagator,OpenTelemetrySpanExt) is unchanged across the bump.