Skip to content

Upgrade dependencies - #477

Merged
Danielius1922 merged 3 commits into
mainfrom
adam/feature/update-deps
Jun 3, 2024
Merged

Upgrade dependencies#477
Danielius1922 merged 3 commits into
mainfrom
adam/feature/update-deps

Conversation

@Danielius1922

@Danielius1922 Danielius1922 commented Jun 1, 2024

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated linting tool version to improve code quality checks.
    • Updated base Alpine image version for better security and performance in Dockerfiles.

golangci/golangci-lint-action: v5 -> v6
alpine: 3.19 -> 3.20
@coderabbitai

coderabbitai Bot commented Jun 1, 2024

Copy link
Copy Markdown

Walkthrough

This update primarily focuses on upgrading dependencies and refining configurations. The golangci-lint action in the GitHub workflows has been updated to a newer version, and several linters have been removed from the .golangci.yml file. Additionally, the base Alpine image version has been updated in two Dockerfiles to enhance security and compatibility.

Changes

Files Change Summary
.github/workflows/golangci-lint.yml Updated golangci/golangci-lint-action from v5 to v6.
.golangci.yml Removed execinquery, exhaustivestruct, ifshort, and maligned linters; adjusted other linter configurations.
cmd/bridge-device/Dockerfile Changed base Alpine image version from 3.19 to 3.20 for the security-provider stage.
test/cloud-server/Dockerfile Updated base image from alpine:3.19 to alpine:3.20 for the service container setup.

Poem

In the code's grand dance, a step anew,
Linters trimmed, and versions grew.
Alpine's heights, from 19 to 20,
Security strong, improvements plenty.
A rabbit's joy in each commit,
For progress made bit by bit.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter

codecov-commenter commented Jun 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (d8ca4ac) to head (59b6300).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   76.84%   76.85%   +0.01%     
==========================================
  Files         121      121              
  Lines        7225     7225              
==========================================
+ Hits         5552     5553       +1     
  Misses       1084     1084              
+ Partials      589      588       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Direct:
github.com/go-json-experiment/json v0.0.0-20240524174822-2d9f40f7385b
github.com/pion/dtls/v2 v2.2.8-0.20240601040544-edc7ad02205f
github.com/plgd-dev/go-coap/v3 v3.3.5-0.20240603125124-ff2c47df37c4
google.golang.org/grpc v1.64.0

Indirect:
golang.org/x/crypto v0.23.0
golang.org/x/exp v0.0.0-20240531132922-fd00a4e0eefc
golang.org/x/net v0.25.0
golang.org/x/sys v0.20.0
google.golang.org/genproto/googleapis/rpc v0.0.0-20240528184218-531527333157
google.golang.org/protobuf v1.34.1
@Danielius1922
Danielius1922 force-pushed the adam/feature/update-deps branch from f9f90e9 to 59b6300 Compare June 3, 2024 12:55
@Danielius1922
Danielius1922 marked this pull request as ready for review June 3, 2024 12:58

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (2)
cmd/bridge-device/Dockerfile (1)

Line range hint 3-3: Pin versions in apk add commands to ensure reproducibility.

- RUN apk add --no-cache curl git build-base
+ RUN apk add --no-cache curl=<version> git=<version> build-base=<version>

- RUN apk add -U --no-cache ca-certificates
+ RUN apk add -U --no-cache ca-certificates=<version>

Also applies to: 14-14

Tools
Hadolint

[warning] 14-14: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

test/cloud-server/Dockerfile (1)

Line range hint 2-2: Pin versions in apk add commands to ensure reproducibility.

- RUN apk add --no-cache curl git build-base
+ RUN apk add --no-cache curl=<version> git=<version> build-base=<version>

- RUN apk add --no-cache bash
+ RUN apk add --no-cache bash=<version>

Also applies to: 11-11

Tools
Hadolint

[info] 8-8: Multiple consecutive RUN instructions. Consider consolidation.


[warning] 11-11: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d8ca4ac and 59b6300.

Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (4)
  • .github/workflows/golangci-lint.yml (1 hunks)
  • .golangci.yml (2 hunks)
  • cmd/bridge-device/Dockerfile (1 hunks)
  • test/cloud-server/Dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/golangci-lint.yml
Additional context used
Hadolint
cmd/bridge-device/Dockerfile

[warning] 3-3: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>


[warning] 14-14: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

test/cloud-server/Dockerfile

[warning] 2-2: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>


[info] 8-8: Multiple consecutive RUN instructions. Consider consolidation.


[warning] 11-11: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

Additional comments not posted (3)
cmd/bridge-device/Dockerfile (1)

13-13: Base image upgraded to Alpine 3.20 as intended.

test/cloud-server/Dockerfile (1)

10-10: Base image upgraded to Alpine 3.20 as intended.

.golangci.yml (1)

Line range hint 1-1: Linter configurations updated as intended.

Comment thread test/cloud-server/Dockerfile
@sonarqubecloud

sonarqubecloud Bot commented Jun 3, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Danielius1922
Danielius1922 merged commit 6c9b1dc into main Jun 3, 2024
@Danielius1922
Danielius1922 deleted the adam/feature/update-deps branch June 3, 2024 13:16
@coderabbitai coderabbitai Bot mentioned this pull request Sep 14, 2024
@coderabbitai coderabbitai Bot mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants