Upgrade dependencies - #477
Conversation
golangci/golangci-lint-action: v5 -> v6
alpine: 3.19 -> 3.20
WalkthroughThis update primarily focuses on upgrading dependencies and refining configurations. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 76.84% 76.85% +0.01%
==========================================
Files 121 121
Lines 7225 7225
==========================================
+ Hits 5552 5553 +1
Misses 1084 1084
+ Partials 589 588 -1 ☔ View full report in Codecov by Sentry. |
Direct: github.com/go-json-experiment/json v0.0.0-20240524174822-2d9f40f7385b github.com/pion/dtls/v2 v2.2.8-0.20240601040544-edc7ad02205f github.com/plgd-dev/go-coap/v3 v3.3.5-0.20240603125124-ff2c47df37c4 google.golang.org/grpc v1.64.0 Indirect: golang.org/x/crypto v0.23.0 golang.org/x/exp v0.0.0-20240531132922-fd00a4e0eefc golang.org/x/net v0.25.0 golang.org/x/sys v0.20.0 google.golang.org/genproto/googleapis/rpc v0.0.0-20240528184218-531527333157 google.golang.org/protobuf v1.34.1
f9f90e9 to
59b6300
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
cmd/bridge-device/Dockerfile (1)
Line range hint
3-3: Pin versions in apk add commands to ensure reproducibility.- RUN apk add --no-cache curl git build-base + RUN apk add --no-cache curl=<version> git=<version> build-base=<version> - RUN apk add -U --no-cache ca-certificates + RUN apk add -U --no-cache ca-certificates=<version>Also applies to: 14-14
Tools
Hadolint
[warning] 14-14: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>test/cloud-server/Dockerfile (1)
Line range hint
2-2: Pin versions in apk add commands to ensure reproducibility.- RUN apk add --no-cache curl git build-base + RUN apk add --no-cache curl=<version> git=<version> build-base=<version> - RUN apk add --no-cache bash + RUN apk add --no-cache bash=<version>Also applies to: 11-11
Tools
Hadolint
[info] 8-8: Multiple consecutive
RUNinstructions. Consider consolidation.
[warning] 11-11: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (4)
- .github/workflows/golangci-lint.yml (1 hunks)
- .golangci.yml (2 hunks)
- cmd/bridge-device/Dockerfile (1 hunks)
- test/cloud-server/Dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/golangci-lint.yml
Additional context used
Hadolint
cmd/bridge-device/Dockerfile
[warning] 3-3: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
[warning] 14-14: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>test/cloud-server/Dockerfile
[warning] 2-2: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
[info] 8-8: Multiple consecutive
RUNinstructions. Consider consolidation.
[warning] 11-11: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
Additional comments not posted (3)
cmd/bridge-device/Dockerfile (1)
13-13: Base image upgraded to Alpine 3.20 as intended.test/cloud-server/Dockerfile (1)
10-10: Base image upgraded to Alpine 3.20 as intended..golangci.yml (1)
Line range hint
1-1: Linter configurations updated as intended.
|




Summary by CodeRabbit