Fix issues reported by golangsci-lint

[Danielius1922]

Summary by CodeRabbit

• New Features

  • Enhanced artifact upload process in GitHub Actions to include hidden coverage files.
  • Introduced a new helper function for converting time durations, improving configuration handling.
  • Added a new utility for type casting between integer types to promote code reusability.

• Bug Fixes

  • Improved error handling for configuration parameters related to time durations.

• Documentation

  • Updated comments for clarity on coverage files during artifact upload.

• Refactor

  • Adjusted type casting in various methods to enhance type safety and maintainability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes encompass updates to multiple files, enhancing the artifact upload process in GitHub Actions, modifying linting rules, refining type handling in configuration parameters, and introducing a new type casting utility. The updates improve type safety, error handling, and the overall structure of the codebase, while also adding a direct dependency on an experimental Go module.

Changes

File	Change Summary
.github/workflows/test-with-cfg.yml, .golangci.yml	Enhanced artifact upload process with coverage file comments and inclusion of hidden files; enabled copyloopvar linter and removed exportloopref linter.
client/client.go, internal/math/cast.go	Changed DeviceCacheExpirationSeconds from int64 to uint64 and added toDuration function for time conversion; introduced CastTo function for generic type casting.
client/core/discover.go	Modified DialDiscoveryAddresses to use type casting with math.CastTo[uint16] for msgIDudp4.
go.mod	Added golang.org/x/exp as a direct dependency and removed its indirect requirement.
schema/credential/credential.go, schema/pstat/pstat.go	Updated String methods to cast values to uint8 and uint16 for better representation of unknown credential and operational modes.
schema/platform/platform.go	Introduced math.CastTo for version component extraction in GetVersion, replacing direct type casting.

Sequence Diagram(s)

sequenceDiagram
    participant Config
    participant Client
    participant Duration
    participant Math

    Config->>Client: Provide configuration values
    Client->>Duration: Convert seconds to Duration
    Duration-->>Client: Return Duration
    Client-->>Config: Return configured Client

Loading

🐰 "In the code, changes abound,
With types and casts, new paths are found.
From int to uint, we hop with glee,
A safer world for you and me!
So let’s celebrate, with joy and cheer,
For every change brings us near!" 🐇✨

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (d54e225) to head (9b786d3).

Files with missing lines	Patch %	Lines
client/client.go	28.00%	14 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   76.84%   76.83%   -0.02%     
==========================================
  Files         121      122       +1     
  Lines        7225     7234       +9     
==========================================
+ Hits         5552     5558       +6     
- Misses       1084     1088       +4     
+ Partials      589      588       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate failed

Failed conditions
57.6% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud