Skip to content

Gaussian implementation (erroneously?) has an unused parameter #4

Description

@Kermalis

I tried to look at the other language implementations and couldn't make heads or tails of it.

The issue is in polevl() here: https://github.com/pocketcombats/openskill-java/blob/master/src/main/java/com/pocketcombats/openskill/math/Gaussian.java#L67

The N parameter is unused. This N parameter is passed with very specific values and seems important, so it's looking like it was implemented incorrectly somehow, but as I said, I'm not entirely sure how the N should be used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions